From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AOBgNOvYtmgaJhIAWB0awg (envelope-from ) for ; Tue, 02 Sep 2025 07:45:47 -0400 Received: by simark.ca (Postfix, from userid 112) id C61751E04C; Tue, 02 Sep 2025 07:45:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 242311E043 for ; Tue, 02 Sep 2025 07:45:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A463F3857806 for ; Tue, 2 Sep 2025 11:45:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A463F3857806 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id A2A9E3858039 for ; Tue, 2 Sep 2025 11:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2A9E3858039 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2A9E3858039 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756812888; cv=none; b=iHpSYXRtQRZJ4j+VI+InIfPpemNA4cGh1uWCqAhI7/eXKlbgCRpmRQMYHECz+54+VVid7P/iEpCO4DCOZs9D80b8fzzwDshx986J6+o7oB5HoYucMfieci6fbLgqmpwz2MSFJGK3tSNyM6jSV7WFlXn/o6WGJCDTmc3Q8iPlJzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756812888; c=relaxed/simple; bh=EKHkopS3XX0n+FNuUDjkcqrJEJBePZ+ptGGXRIKrdxs=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=paBXHiZKfjfioeufhlbUdYd6D47yhzDvyINzQ9diaIeXTmziR0owwKV+YAbaZGRzrp8FhTJvxR8ocaSN5q0Ub72Us3nmwlO4xDX+2bf5TxFv+qtC/Z9W2Cuwzs4wsJli401kF/PG9WHLWCryD2Qec6w3hYK5PaPGyCpwd/GNNZg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2A9E3858039 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45b869d35a0so18810725e9.1 for ; Tue, 02 Sep 2025 04:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756812887; x=1757417687; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cEe7C9hkHvKr8FSSYqhEWICgaDYwHyefDNNMN/FCa5k=; b=QDidJj+0vskpq+0rfziDFBA4wnDX1E1v5xVq6+HLUaY4xlp9GIm6TGnvwgpbj+wVkL 0niuJh2Qn7iVSOEqZRfypfSghCT0uKfyWMf4JoCUxlG0U79sbUa17eXP1T9+zhwj0nwI UG+ovBW6eM4CWz8V5k9AzT0ROk5DdJtvdzfHrGBNSnWW/IML8OgFksgfuZ08EweU2dlz hHG/zov5srvrgYRz5KP22dFC0yInL+1zzlHhHaO+phYkYgYcKul0ikmhloTJNlyDEdSj 1zIkMtELjEfSzCCgd/bm6HQfRAvnxVY6LJFnGEN7OQJXz7anyhGLMam0UCu5g7BuEiUo I7MQ== X-Forwarded-Encrypted: i=1; AJvYcCUL57JiezecOkrO8YqPdeeozFsQe3krZqi7MNj+PpgDzI42HWFpql2hdhu/JFk0G5myzoz3x8qpI2IV+Q==@sourceware.org X-Gm-Message-State: AOJu0YwDQO0SS+MnR9Cq6E4VG14hM6BV/GuoaYAy237oSOdVB97248pH GGmRPXynaUR1HheECQug7LcjY9R9JizAasHr5XxyhxaRokuK/Vs/QH+iNtxnjA== X-Gm-Gg: ASbGncsvnbfAzKudW8pkqe1zoBkX9G+vTlcS0dXTakMxkT1/6Rj19m3LchboYFB6g/V +zqxxZ2PQ37fv0b8cvSiY63LcnRF3YI93fVBptldvJ4U4PKVyYXoSCzjqwUkMHyAGZzvwVimOKq jXE6HWFrbUmPdYvl+Ksw0N06zu47WYAvCSa4/HUwORXzT4g3K2zY1v7NqLhjXzFZCJBAxMVjQ/k 1es6/tPlMyUkYIO4ow8pJtqIHySY8jgj1FiKNB3Pqd+XNv1UCVNtavQ32KYrtnR+E9pIPSbvGr1 57D5ZRyMAi6O0vGgvi0USRtL4+ZBy3xUvZqmNACIAfQ+FwdkxYJOrJA0o93rOHpZ6baDSv7uRzt lAUJImzulZkIMnDOAlr+r+mE50h0RS1gAVVDzBS/scwuuneEYLklJgw+Gs7OcJDIUkpl03Suu6g == X-Google-Smtp-Source: AGHT+IG75Ir3Sjkejo/yLV1IY9JuMxxDlJL9SL8OjyqU4MRqJVKw80SS2Xe3VuoXKjgGHKYioqBFog== X-Received: by 2002:a05:6000:2281:b0:3ca:83e2:6339 with SMTP id ffacd0b85a97d-3d1e02cb35fmr8035046f8f.49.1756812887360; Tue, 02 Sep 2025 04:34:47 -0700 (PDT) Received: from ?IPV6:2001:8a0:fad8:400:6c2e:fe21:d70b:ee7e? ([2001:8a0:fad8:400:6c2e:fe21:d70b:ee7e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf3458a67esm19379419f8f.62.2025.09.02.04.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 04:34:46 -0700 (PDT) Message-ID: <4384029d-6ddb-474f-aea9-17b1e146d439@palves.net> Date: Tue, 2 Sep 2025 12:34:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Fix host_file_normalize_mingw To: Tom de Vries , gdb-patches@sourceware.org References: <20250827131439.27473-1-tdevries@suse.de> <20250827131439.27473-3-tdevries@suse.de> <64decff4-3ff0-4033-812e-df98f7fb6912@palves.net> From: Pedro Alves Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, On 2025-09-02 10:18, Tom de Vries wrote: > I ran the test-case on both x86_64-linux and msys2-ucrt64, and it passed in both cases, so I think it should be fine. > > Feel free to commit this together with the first patch, or perhaps to combined into one patch. > > Given that the second patch now changes the setup of the test-case, I think squashing makes more sense. I tried a combined patch, but it makes it hard to see the changes to host_file_normalize_mingw, because we'd be moving the code to a separate procedure and changing it at the same time. So I kept the patches separate, but adjusted the first patch to use the "proc test" way. I think it makes sense this way, and lets me keep you as main author of that patch. I sent it all as a v2 here: https://inbox.sourceware.org/gdb-patches/20250902112742.1407890-1-pedro@palves.net/T/ I didn't merge it yet, I wanted to give you a chance to double check the commit logs. The resulting code is the exact same, though. Pedro Alves