From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0z6sNbTatmhDJxIAWB0awg (envelope-from ) for ; Tue, 02 Sep 2025 07:53:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=17rGcN8f; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1EGb55VV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=17rGcN8f; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1EGb55VV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C3E491E043; Tue, 02 Sep 2025 07:53:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D991B1E043 for ; Tue, 02 Sep 2025 07:53:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 535D13858039 for ; Tue, 2 Sep 2025 11:53:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 535D13858039 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=17rGcN8f; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1EGb55VV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=17rGcN8f; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1EGb55VV Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 0F9D9385840B for ; Tue, 2 Sep 2025 11:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F9D9385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F9D9385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756813491; cv=none; b=k+4Xo10Adxl3oEVPUhm4uSit9hSprBgKbWAefPIFxs0Q/BRrd3PX1GO3fTxvLZf6PpUS9NYIOB8eWv+WIgHrREZON4cV9bpwYRTgWcxvLB+uo5iVp4uAO6CLyhDYJK0ZvSvfVxMNfdBdWajapdZwSwFjJsZb++ehH52BjQgBpfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756813491; c=relaxed/simple; bh=7KT4mmcbjkMgYaRo0C6XQji4nZiP/n414tm0c6FkvB4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=o5B7t4mR0SSqeAmv8Y4SlvuVC0xy6xDhMmv6JTa7tCr88p4nOhsQ64/BwTGibCPDhpNWM8AOfU0apV+Fj/oa5lSCXOPrh9MR9zF2P1eFHGhLbxXoghhPDkJhmDO1v4bjJY/EVqoF/aMk6plzY5+nF4MtN2ybiRcm2UjZUMaeO4c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F9D9385840B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 044011F38A; Tue, 2 Sep 2025 11:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756813490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7+DOwtPMoIBFjYeGWrf2rq9470b8+BqL5DOOfIRdoA=; b=17rGcN8fk0X9NZ4HS+zrE6eMnQLoG24W26ybYlcJDJP+pZlrfE6YSxZLDOfWCr1GokpdyQ rVVpO0OFaFl10PMSje6sOnVJl70K7tFt1thMia9z8F5WJpBiy01ihutYPZCvLPWbrouYKm fJcFGJ1Gcdn2hEu0E0UG5h76r6PZBds= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756813490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7+DOwtPMoIBFjYeGWrf2rq9470b8+BqL5DOOfIRdoA=; b=1EGb55VVu+iI6UwBwILLTJgs0nE0oIbAxgDcJJFGKzk03G040oR8QIy0UVj+jqvBbvsq6V X/vqZMyKzQYYIpDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=17rGcN8f; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1EGb55VV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756813490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7+DOwtPMoIBFjYeGWrf2rq9470b8+BqL5DOOfIRdoA=; b=17rGcN8fk0X9NZ4HS+zrE6eMnQLoG24W26ybYlcJDJP+pZlrfE6YSxZLDOfWCr1GokpdyQ rVVpO0OFaFl10PMSje6sOnVJl70K7tFt1thMia9z8F5WJpBiy01ihutYPZCvLPWbrouYKm fJcFGJ1Gcdn2hEu0E0UG5h76r6PZBds= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756813490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7+DOwtPMoIBFjYeGWrf2rq9470b8+BqL5DOOfIRdoA=; b=1EGb55VVu+iI6UwBwILLTJgs0nE0oIbAxgDcJJFGKzk03G040oR8QIy0UVj+jqvBbvsq6V X/vqZMyKzQYYIpDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E0FCF13882; Tue, 2 Sep 2025 11:44:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O6RqNbHYtmiCOQAAD6G6ig (envelope-from ); Tue, 02 Sep 2025 11:44:49 +0000 Message-ID: Date: Tue, 2 Sep 2025 13:44:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Fix host_file_normalize_mingw To: Pedro Alves , gdb-patches@sourceware.org References: <20250827131439.27473-1-tdevries@suse.de> <20250827131439.27473-3-tdevries@suse.de> <64decff4-3ff0-4033-812e-df98f7fb6912@palves.net> <4384029d-6ddb-474f-aea9-17b1e146d439@palves.net> Content-Language: en-US From: Tom de Vries In-Reply-To: <4384029d-6ddb-474f-aea9-17b1e146d439@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 044011F38A X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:dkim,suse.de:mid]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/2/25 13:34, Pedro Alves wrote: > Hi Tom, > > On 2025-09-02 10:18, Tom de Vries wrote: > >> I ran the test-case on both x86_64-linux and msys2-ucrt64, and it passed in both cases, so I think it should be fine. >> >> Feel free to commit this together with the first patch, or perhaps to combined into one patch. >> >> Given that the second patch now changes the setup of the test-case, I think squashing makes more sense. > > I tried a combined patch, but it makes it hard to see the changes to host_file_normalize_mingw, because we'd > be moving the code to a separate procedure and changing it at the same time. > > So I kept the patches separate, but adjusted the first patch to use the "proc test" way. I think it makes > sense this way, and lets me keep you as main author of that patch. > Hi Pedro, I see, agreed. > I sent it all as a v2 here: > https://inbox.sourceware.org/gdb-patches/20250902112742.1407890-1-pedro@palves.net/T/ > > I didn't merge it yet, I wanted to give you a chance to double check the commit logs. > The resulting code is the exact same, though. LGTM, please apply. Thanks, - Tom