Re: [PATCH][gdb/testsuite] Dump /proc/cpuinfo into gdb.log

[Pedro Alves <pedro@palves.net>]

On 2021-09-23 11:06 p.m., Tom de Vries via Gdb-patches wrote:

>  gdb/testsuite/gdb.testsuite/dump-system-info.exp | 48 ++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.testsuite/dump-system-info.exp b/gdb/testsuite/gdb.testsuite/dump-system-info.exp
> new file mode 100644
> index 00000000000..bf181469bd5
> --- /dev/null
> +++ b/gdb/testsuite/gdb.testsuite/dump-system-info.exp
> @@ -0,0 +1,48 @@
> +# Copyright 2021 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# The purpose of this test-case is to dump /proc/cpuinfo and similar system
> +# info into gdb.log.
> +
> +# Check if /proc/cpuinfo is available.
> +set res [remote_exec target "test -r /proc/cpuinfo"]
> +set status [lindex $res 0]
> +set output [lindex $res 1]

OOC, why "test -r" -> "cat" instead of "cat" straight away, which
is basically what is done for the other dumps?

Consider factoring out a proc, like (untested, written in email):

proc dump_info {cmd {what ""}} {

  if {$what == ""} {
    set what $cmd
  }

  set res [remote_exec target $cmd]
  set status [lindex $res 0]
  set output [lindex $res 1]

  if { $status == 0 } {
    verbose -log "$what available, dumping:\n$output"
  } else {
    verbose -log "$what not available"
  }
}

dump_info "cat /proc/cpuinfo" "Cpuinfo"
dump_info "uname -a"
dump_info "lsb_release -a"

> +
> +if { $status == 0 && $output == "" } {
> +    verbose -log "Cpuinfo available, dumping:"
> +    remote_exec target "cat /proc/cpuinfo"
> +} else {
> +    verbose -log "Cpuinfo not available"
> +}
> +
> +set res [remote_exec target "lsb_release -a"]
> +set status [lindex $res 0]
> +set output [lindex $res 1]
> +
> +if { $status == 0 } {
> +    verbose -log "lsb_release -a availabe, dumping:\n$output"

Typo: "availabe".

> +} else {
> +    verbose -log "lsb_release -a not available"
> +}
> +
> +set res [remote_exec target "uname -a"]
> +set status [lindex $res 0]
> +set output [lindex $res 1]
> +
> +if { $status == 0 } {
> +    verbose -log "uname -a availabe, dumping:\n$output"
> +} else {
> +    verbose -log "uname -a not available"
> +}
>