From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ykKeH+PCTWGeNgAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 08:21:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 6F86E1EE25; Fri, 24 Sep 2021 08:21:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7AB6C1EDF0 for ; Fri, 24 Sep 2021 08:21:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF2103858403 for ; Fri, 24 Sep 2021 12:21:53 +0000 (GMT) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by sourceware.org (Postfix) with ESMTPS id C44F4385840A for ; Fri, 24 Sep 2021 12:21:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C44F4385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id i23so27025273wrb.2 for ; Fri, 24 Sep 2021 05:21:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ESiGVsz33NYdWMDAoW4jvp/sjiOK76Sdt0EDRqpr2rA=; b=pHjFHl4hp40EOpV0N++XlkVqjuvXnHNLUIp+U9BXdJ+HFzBSH1k9OnLxLknoJzWa2e 0B/j7bb6ieIU2UdYInsn1h4HWPloqhfjuNbfbV4as6//BrEd+585AhjwjMIyrZ0hUkYE gTIw+WZPbjMeOm0eVURUIUpcJ9HY3gb3Fo99luZlN002/kbyxG4kZskOqHB7V6Pbeohd LujiMRKMIpWaYjT0fgNMoOakrOKLN/ekjIIvTwfJgzYdJDs2lLuzM6aADvptJYysCr2p UZmgMmxVjEmJwEzsZpUwSKbiHTljAWDdwTzdBUfh0J7b7ZaKjCLPb6LGkuN9vocV7fto m2tQ== X-Gm-Message-State: AOAM530pLihyS8IpIqVNMLOmdROz/brFWEw9v9jjgm2NuvI3d1FuaV11 JQLcov1YIkrXYH6EKsSjQF6awU4oCowVmQ== X-Google-Smtp-Source: ABdhPJxTlBhJ3zSNdKT3zWUmGQbEL+l0jyDUIDrYajV0amHh8GdULA4kpR6trLxQCdJCl9OciENeAw== X-Received: by 2002:a5d:4d02:: with SMTP id z2mr11491531wrt.8.1632486101114; Fri, 24 Sep 2021 05:21:41 -0700 (PDT) Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt. [2.83.100.144]) by smtp.gmail.com with ESMTPSA id w5sm8006827wra.87.2021.09.24.05.21.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 05:21:40 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Dump /proc/cpuinfo into gdb.log From: Pedro Alves To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org References: <20210921080157.GA18967@delia> <671f08cc-cc93-f36e-563d-20f2be20488e@polymtl.ca> Message-ID: Date: Fri, 24 Sep 2021 13:21:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-23 11:06 p.m., Tom de Vries via Gdb-patches wrote: > gdb/testsuite/gdb.testsuite/dump-system-info.exp | 48 ++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/gdb/testsuite/gdb.testsuite/dump-system-info.exp b/gdb/testsuite/gdb.testsuite/dump-system-info.exp > new file mode 100644 > index 00000000000..bf181469bd5 > --- /dev/null > +++ b/gdb/testsuite/gdb.testsuite/dump-system-info.exp > @@ -0,0 +1,48 @@ > +# Copyright 2021 Free Software Foundation, Inc. > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# The purpose of this test-case is to dump /proc/cpuinfo and similar system > +# info into gdb.log. > + > +# Check if /proc/cpuinfo is available. > +set res [remote_exec target "test -r /proc/cpuinfo"] > +set status [lindex $res 0] > +set output [lindex $res 1] OOC, why "test -r" -> "cat" instead of "cat" straight away, which is basically what is done for the other dumps? Consider factoring out a proc, like (untested, written in email): proc dump_info {cmd {what ""}} { if {$what == ""} { set what $cmd } set res [remote_exec target $cmd] set status [lindex $res 0] set output [lindex $res 1] if { $status == 0 } { verbose -log "$what available, dumping:\n$output" } else { verbose -log "$what not available" } } dump_info "cat /proc/cpuinfo" "Cpuinfo" dump_info "uname -a" dump_info "lsb_release -a" > + > +if { $status == 0 && $output == "" } { > + verbose -log "Cpuinfo available, dumping:" > + remote_exec target "cat /proc/cpuinfo" > +} else { > + verbose -log "Cpuinfo not available" > +} > + > +set res [remote_exec target "lsb_release -a"] > +set status [lindex $res 0] > +set output [lindex $res 1] > + > +if { $status == 0 } { > + verbose -log "lsb_release -a availabe, dumping:\n$output" Typo: "availabe". > +} else { > + verbose -log "lsb_release -a not available" > +} > + > +set res [remote_exec target "uname -a"] > +set status [lindex $res 0] > +set output [lindex $res 1] > + > +if { $status == 0 } { > + verbose -log "uname -a availabe, dumping:\n$output" > +} else { > + verbose -log "uname -a not available" > +} >