Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
	GDB Patches <gdb-patches@sourceware.org>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent"
Date: Tue, 13 Feb 2018 04:58:00 -0000	[thread overview]
Message-ID: <c60a4d66-6fa5-fd06-a86d-8184d84ac1a0@simark.ca> (raw)
In-Reply-To: <20180131210430.23787-1-sergiodj@redhat.com>

On 2018-01-31 04:04 PM, Sergio Durigan Junior wrote:
> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB
> with ncursesw") modified our configure.ac and included the check for
> "ncursesw" when searching for "waddstr".  However, there's one more
> place where we should check for "ncursesw" first:
> 
>   AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
> 
> This patch changes the order of the libraries to be searched when
> looking for "tgetent", and puts "ncursesw" before "curses ...".
> 
> This is another patch we carry on Fedora GDB.

I think it makes sense, but can you expand on why this is needed?

Thanks,

Simon


  parent reply	other threads:[~2018-02-13  4:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 21:04 Sergio Durigan Junior
2018-02-10  1:43 ` Sergio Durigan Junior
2018-02-13  4:58 ` Simon Marchi [this message]
     [not found]   ` <87d118hfs7.fsf@redhat.com>
2018-02-14  1:28     ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c60a4d66-6fa5-fd06-a86d-8184d84ac1a0@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox