Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent"
Date: Sat, 10 Feb 2018 01:43:00 -0000	[thread overview]
Message-ID: <871shty5yu.fsf@redhat.com> (raw)
In-Reply-To: <20180131210430.23787-1-sergiodj@redhat.com> (Sergio Durigan	Junior's message of "Wed, 31 Jan 2018 16:04:30 -0500")

On Wednesday, January 31 2018, I wrote:

> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB
> with ncursesw") modified our configure.ac and included the check for
> "ncursesw" when searching for "waddstr".  However, there's one more
> place where we should check for "ncursesw" first:
>
>   AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
>
> This patch changes the order of the libraries to be searched when
> looking for "tgetent", and puts "ncursesw" before "curses ...".
>
> This is another patch we carry on Fedora GDB.

Ping.

> gdb/ChangeLog:
> 2018-01-31  Sergio Durigan Junior  <sergiodj@redhat.com>
>
> 	* configure.ac: Check for "ncursesw" first when searching for
> 	"tgetent".
> 	* configure: Regenerate.
> ---
>  gdb/configure    | 2 +-
>  gdb/configure.ac | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/configure b/gdb/configure
> index 81b35af521..c552c1ab1f 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -8912,7 +8912,7 @@ return tgetent ();
>    return 0;
>  }
>  _ACEOF
> -for ac_lib in '' termcap tinfo curses ncursesw ncurses; do
> +for ac_lib in '' termcap tinfo ncursesw curses ncurses; do
>    if test -z "$ac_lib"; then
>      ac_res="none required"
>    else
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index 125e5f30e6..a73f72d0a8 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -609,7 +609,7 @@ case $host_os in
>  esac
>  
>  # These are the libraries checked by Readline.
> -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
> +AC_SEARCH_LIBS(tgetent, [termcap tinfo ncursesw curses ncurses])
>  
>  if test "$ac_cv_search_tgetent" = no; then
>    CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
> -- 
> 2.14.3

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  reply	other threads:[~2018-02-10  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 21:04 Sergio Durigan Junior
2018-02-10  1:43 ` Sergio Durigan Junior [this message]
2018-02-13  4:58 ` Simon Marchi
     [not found]   ` <87d118hfs7.fsf@redhat.com>
2018-02-14  1:28     ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871shty5yu.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox