From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126997 invoked by alias); 10 Feb 2018 01:43:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126986 invoked by uid 89); 10 Feb 2018 01:43:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Feb 2018 01:43:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75D0840FB633 for ; Sat, 10 Feb 2018 01:43:40 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0147D1010070; Sat, 10 Feb 2018 01:43:37 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Jan Kratochvil Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent" References: <20180131210430.23787-1-sergiodj@redhat.com> Date: Sat, 10 Feb 2018 01:43:00 -0000 In-Reply-To: <20180131210430.23787-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 31 Jan 2018 16:04:30 -0500") Message-ID: <871shty5yu.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00162.txt.bz2 On Wednesday, January 31 2018, I wrote: > Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB > with ncursesw") modified our configure.ac and included the check for > "ncursesw" when searching for "waddstr". However, there's one more > place where we should check for "ncursesw" first: > > AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > > This patch changes the order of the libraries to be searched when > looking for "tgetent", and puts "ncursesw" before "curses ...". > > This is another patch we carry on Fedora GDB. Ping. > gdb/ChangeLog: > 2018-01-31 Sergio Durigan Junior > > * configure.ac: Check for "ncursesw" first when searching for > "tgetent". > * configure: Regenerate. > --- > gdb/configure | 2 +- > gdb/configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index 81b35af521..c552c1ab1f 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -8912,7 +8912,7 @@ return tgetent (); > return 0; > } > _ACEOF > -for ac_lib in '' termcap tinfo curses ncursesw ncurses; do > +for ac_lib in '' termcap tinfo ncursesw curses ncurses; do > if test -z "$ac_lib"; then > ac_res="none required" > else > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 125e5f30e6..a73f72d0a8 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -609,7 +609,7 @@ case $host_os in > esac > > # These are the libraries checked by Readline. > -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > +AC_SEARCH_LIBS(tgetent, [termcap tinfo ncursesw curses ncurses]) > > if test "$ac_cv_search_tgetent" = no; then > CONFIG_OBS="$CONFIG_OBS stub-termcap.o" > -- > 2.14.3 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/