From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72430 invoked by alias); 13 Feb 2018 04:58:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72337 invoked by uid 89); 13 Feb 2018 04:58:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=our X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 04:58:43 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 44D561E75A; Mon, 12 Feb 2018 23:58:42 -0500 (EST) Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent" To: Sergio Durigan Junior , GDB Patches Cc: Jan Kratochvil References: <20180131210430.23787-1-sergiodj@redhat.com> From: Simon Marchi Message-ID: Date: Tue, 13 Feb 2018 04:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180131210430.23787-1-sergiodj@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00182.txt.bz2 On 2018-01-31 04:04 PM, Sergio Durigan Junior wrote: > Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB > with ncursesw") modified our configure.ac and included the check for > "ncursesw" when searching for "waddstr". However, there's one more > place where we should check for "ncursesw" first: > > AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > > This patch changes the order of the libraries to be searched when > looking for "tgetent", and puts "ncursesw" before "curses ...". > > This is another patch we carry on Fedora GDB. I think it makes sense, but can you expand on why this is needed? Thanks, Simon