Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ronald Hecht <ronald.hecht@gmx.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb: z80: Fix endless backtrace loop and assertion crashes
Date: Mon, 15 Jun 2026 08:49:00 +0200	[thread overview]
Message-ID: <c53456ac-7a28-4125-a984-b3e92b3c845e@gmx.de> (raw)
In-Reply-To: <20260614150230.2fd33d6e@f44-mesa-1>

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

|Hi |Kevin,

Thanks for taking the time to review the patch.

|You are right that a hardcoded 4 is perfect for the 16-bit Z80 
(covering two pushed register pairs), but it would fall short for the 
eZ80 ADL mode where two pushed registers take up six bytes. Making the 
limit dependent on the architecture's address width is a reasonable 
solution. Since `addr_len` is already available in the function, I will 
change it to `2 * addr_len`. What do you think? I will update the 
comments as you suggested: 1. Mentioned conditional CALLs alongside the 
unconditional ones. 2. Updated the old "overflow" comment inside the 
break block to accurately reflect both exit conditions. Best regards, Ronald|

[-- Attachment #2: Type: text/html, Size: 1301 bytes --]

  reply	other threads:[~2026-06-15  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05 18:56 [PATCH] " Ronald Hecht
2026-06-06 19:40 ` Kevin Buettner
2026-06-07  7:36   ` Ronald Hecht
2026-06-07  7:48   ` [PATCH v2] " Ronald Hecht
2026-06-14 22:06     ` Kevin Buettner
2026-06-15  6:49       ` Ronald Hecht [this message]
2026-06-15  7:04       ` [PATCH v3] gdb: z80: Fix endless loop in frame unwinder and validate saved register types Ronald Hecht
2026-06-20 20:11         ` Kevin Buettner
2026-06-23  7:16           ` Ronald Hecht
2026-07-09  3:52             ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c53456ac-7a28-4125-a984-b3e92b3c845e@gmx.de \
    --to=ronald.hecht@gmx.de \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox