From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X2Q8GSemL2qK8wcAWB0awg (envelope-from ) for ; Mon, 15 Jun 2026 03:13:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=ronald.hecht@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=VcHXmeit; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4FCBF1E098; Mon, 15 Jun 2026 03:13:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C12591E024 for ; Mon, 15 Jun 2026 03:13:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9EA04B920FF for ; Mon, 15 Jun 2026 07:13:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9EA04B920FF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=gmx.de header.i=ronald.hecht@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=VcHXmeit Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id C1DA24B920D9 for ; Mon, 15 Jun 2026 07:13:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1DA24B920D9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1DA24B920D9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781507597; cv=none; b=Qumx+fBIQNYTMcWQ/KM8V690Ug+/0R1EVgReomqrdkN5DpreCwdAr4vLcAnnhfqWmAs6FeIfh8oJoMlHT1PSE7w1/kf970Pn/WCNzQRSbd/zjcnPVjzKKDbC3IE0gde1Rx49gSeRnCO8R9YsE1neuAF7w7JymMaKVFjK6DKQx8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781507597; c=relaxed/simple; bh=+3JyRzZjv/3TXP7P2/iiBSc6U3jGHULSn1ViJo6oZ08=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kifil8gOYuWi2XgcYWg7hX+WXzygoEyE2TcC1W+6Cmi4gMi3x4HlFP3AwAoDC+R1hn8y+a0PsEsK81Z6pGg3slknqrlsn8D0s6DDpDqtaw7MUPqo2yU5Y2Wh+zkxKDmSurLsjl3uD6S4S43ZotTskG1Y48GF01wMmk3CUh8w8TA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=gmx.de header.i=ronald.hecht@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=VcHXmeit DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1DA24B920D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1781507595; x=1782112395; i=ronald.hecht@gmx.de; bh=nCtH63lkmAWZedOR4t7OdzqZ69/0LGMSoybCMsltc98=; h=X-UI-Sender-Class:Content-Type:Message-ID:Date:MIME-Version: Subject:To:Cc:References:From:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VcHXmeitD4lmVgzphTRuD+3AA4dethMdj/ji/eZrXBDYzUnllQ6Gl/qDZZCFpqg2 +hHcgseCYVtm8/5u00TNlHY2NHaQLj4nxndd4Pqhc6z/sLqAkqLhqY6K07RCXW356 B+J9EfGA/ovy43RP9XLHkwJ0JS1PRjWFkOSEp2GAetdq+qZ5N2wZRae5vxstA7pLJ VVoiDN+Fwd3LBAuVZpZ71i6S+sH1SheMp3VSuzHMVcesuwVFc7l1k0Jhvjaz2RQ5/ qZXlKcHAl8YOJJq7Ci2JdPJDNfTPH5sAilgHDfes4u42jyAgfumcsdabq3O/Nm54i vzGlvc9HrtIe2zqaTw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from client.hidden.invalid by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M42nY-1wZ1803iE4-00BnW7; Mon, 15 Jun 2026 08:49:00 +0200 Content-Type: multipart/alternative; boundary="------------5cQMDjeTKlQjOIcJLJwTVeVM" Message-ID: Date: Mon, 15 Jun 2026 08:49:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: z80: Fix endless backtrace loop and assertion crashes To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20260606124038.110fa3b3@f42-zbm-amd> <20260607074801.32477-1-ronald.hecht@gmx.de> <20260614150230.2fd33d6e@f44-mesa-1> Content-Language: en-US From: Ronald Hecht In-Reply-To: <20260614150230.2fd33d6e@f44-mesa-1> X-Provags-ID: V03:K1:dAY6R+n7NjIa0FGtiMG+v66LXNTALtUA6vZtYKcbg16YU3NyfPc qm1Cw5+ha9yEyLLQo91QH+oWk+7ae7GE2p9LEwZm9HSJJJbGcNv/W4LLvJj0ME5ukYYWH6B 0Xuq2oX4uDgnzcQMa3R5Tw3FqAQ9u3Aj9zJFRrxLTdRPiyMzFnNoHVPuMUD4+13T4kjdEzK Q4f42/h7TGgqumbyCb4dg== UI-OutboundReport: notjunk:1;M01:P0:JZCBuXlx2Rs=;YWdgnjAPlrgwFppzhpd9XW18Tyc TJArRj+v+3V8Ju4ZkXvJ2gPG4FqPOI/gF9nNep9eRvjWAgR3B0OvjtWW6DV7QfbjHQDseuK+/ UjVdJWJ7lzoStIYWFzx05duAj7jUruT1K7XEHPi2DFrGH3Ks8ho6IHjvP6thhy1TBbt7bH3iO 5m23M5MXN32SxAqp5rKWXVXnvgwaYAYQsyXz+VXzou/KShmoyWhkBm05Qu0T1GfMyXGUuDUY5 mDGP8svCtUEo/9e32/kztqFxPTHMbr0GSarWYYsDtnJgktDA4ogxZdzPn2/VWzu782Puse3qA NWhjJYGWzDP3P6P8jdmVbZ9mrp4TWYpWP4Tshng1sCk98D368AT0FXrTfEvfvFTQdf2woNJ7s axwGr8nWHYZWfAz9+1imacrmnz8u/L+euBbePFBPiK8Cvjgez0GoG3KtSS8v8ggojC2CdVCjY 91JyweiAyvHByEdYCcOuER5BVi8r4YObcDo47lUil5mWoXi1Jk4KMreMahNLln5SXegMyjben yEp+WHsyjYcYvfnz+/f0ua1EsBphfFGH6z14NXKeRxqaWwOpPhOEMkARfLHVAgnYUtLHtj6dQ uD2hqHdj+Nb17JzLs5ZRe3cgUjC7oemhQ+j2hnpDLTvXsHTUoL0IQf9kb6B4e5uQJEARRVHRg ZsikHer6gYu0+dqO9Fr2h/xEtUD4ljnKNmlQxR4deoV3iyJSH9WQQDK6eAOSo2rNaUuosPMRT fEW5Gw/NiGEePgLGR5SwBhc7ZkSjQJb8SOoWsXC+UI6gUp/OYtSI9B3qEZZQCQykAKm7yv5sc Virg0yJlaiH/J9QWkuwj0iNmhbGy9E52lOgTcqfkBG0cyqvtUB5y07ethO/SE4asQEk13jVWa Qtgi7eRiYCnaCdfhRG36UIOFMWFZqkO4ZPyAOgo86zttYfpYHXIlIk4U0R/wfLusdPAcJNMyY +miyUxzaboDEElHt6ysFFTbozf4ZIQA42PE6Rc4QQr3siztLms2m9tHPsQl2T3QF1VaP32FUJ ZM5YB+NzTy6KKrLc5y4APt52rwKNA1QQFhtOvw1kgJ0fg/6Z20ABxBOc82rjrgvEkFzx2hp8C XCw6Z9Kx47dxILZfUd/W8A+rrQxMr8n+2AaUwpG3edYPZPAmKr+WSsBwspOW2EgHqxaTSN7wN DK9s9ibPfQDeiLhOgwtk/AN/MwOb6cEXKEom3OM//07tZk70MpfOXk998kwlPDk5Am4jxE2hv GhKBB6UfurcE9VUXhCmUHGLAnOB6ntwRDrkvK+qwxby3FQ8jsbENwoc7TeAFfQQJ0jXcEzYPL wW8dgFn1fLWevw0PF1xlwfslkdarlD8I0idO/k5x/3EG/tXOLvoblOIMVI93INPDm66uHPQTY q5ViwAosSg5ZUQS2VF1Prehxyuckysb2X4r4ghfXLUhC8vYazvw7WZotkPKyx8KYBbTkWYB2t CBf2ddA1H4UaOJB/SCUnHJG2wJPodEJ4WdWKHvh+5VcOu8R3kPwxtJZqrUr6YSr3XZrmOJXzz pyNsh3SvQQSeS/aZCUpO6IHE4M+B11xuEpe19PE/+SEwADeHuCPjurnxB6ZHrdr//BfNVwkW4 nMLuEbTVAfm4nx7GibPmB6LeVlGuQGNcIh/T7LIhPLj3EztO3XDfgkUWJvPt8yDJlOVkk3XKW 2/NnKFPJwCCzMBot1pmph35o7SqewV5G269e96KvAIoUPuhO603dT1ZSghYRwEsQZaPtpqOx6 LrAh7tVIGXLYQE2SsOrMVGbNm4T4FDBc1ODYGXUdbAbb1fGsF2E1TLGhJhifDEMpagGE8uAUY jOmS7uwppw7FY+BRkTPiqeKIpV2mrgvakwXdYE695YysRiZvLBatVqInvyuHl6jPS6jFniGpg WASsH9BwLPIkUY1fHIsuKmo87ub2fI3uMSf2Gtghwlqsf1k7YeQ5KpSrtBTkv2hopz8RJweE8 i+Swa2YHt3S4SdyM8JB5tkhKUji0SWq/HKHGu84OLi/bTlO/9suvMEhGfZCH3c6Fd4N5780t3 n0TWdk7FIonrbGqHljME3+MAZ2K6e8c48PpiBMJqhC+TKA2wW8izMirQXTBTYTcY29SBVLRY0 c5ff2gB/RHTzZ83tPbljkquNSX9cdqSAfA8Hs/kHGCcLD/k5Y32vvYD/szYXe0VVIL1H7D1o8 Z7qENrj4ir2C+cboc88e9WRIcIekn8dwdjXsCwO6AitokdN4HLOGvi1AnVRDooBH7/9ssgWjx XiVtD2Ek9wlzOHk++A2qgoJapb0OHIbalLr7jODSsw5a+9DqMiYCSSR/8NWiWQTDFVjZCLSwO fPcWT8w8AVAr2lefscwsARmRhmqJ4u1ejY8S5CulpQdiYxjRMDOMKJg3kBEZGK7VJ+/nJwyDx v1VKx26T1MnrGBeh1WKK+YmE914Yo5dyhBYDrdVjHICJ7GbJU1zTw9Jr9bUrn6U/D2q5rX1cX ay0+Pl/y+pH+yfGJJFqlZMY7rAkannqv3bgDQKxXi/UU02HH/muxAgP2vmxycpKitBNiTXYjD y3SHnKkcUSKzBq/aa9Dzyd0EJgeAm7U4P0u9nfINCnI8M3MSoNsVFN1myGf1NBbMb3HzkNRzh s0xiXlrpidnqj0MXzoxZhq1Kcp4ZiBnDmN7GU0p5NxqXJvWOtAM6uz7+FoARGlCT+yIYmh8Ln Add07gTcE/wGf7gSO9z7WEFVuHrZTDS+f0tRAzweuDZa/rE27bF99WS0VdOC05DFom50vJoly aSwL060Ud3CTZl7jqzMbTlVSkQZAPMR8ZLP6WqeQ8yv+YnKArNB9Xo7m6+Y7WSJOMGyVBhyc2 QiCaL8bmYXjUnDvsCduLbakq2hKguoLu60p3k1iOwry2lJ9Xya6cgF9I//xMfEP+69nQ2JhIJ v3vATziof4PEfa3tDC2YYdaSn67e7RVsyggTKVmL13RG401KE1pCjJO9XbFwIZheNCCRL77YJ IgniK3OkJY3lxxD5BEcPFeM/1yMjomdBtyD6MDdcSuPTr3V9+lpRAElyrQLuQoEvh1gAwkO7u nuNs1PtIFe34K1mVKqPV/A1ixFUZSxE/avWUjcWVSeCVJsOZDMifJRkQiSEVBbYjPu3LyveRq EnWyAnf5++V/5gE28G5JQF6bfcg0F1MchZrtKfQqMy4uVwtx8ha1jYqRi9czEzhXL3znzSm18 dRCEUg3Qjli035u5qNjabFmgy1VadJzWmjeTqSoIH9Crrrfr2HtCWvGuugZZ9/6RnhYtOmz2e jREJNkPFFyZrGa7NCYkXOOFpx1r6wBA4dgyh4IFLS9gzZA3T2KjjZ/S+0Kj4KUVbOwiwaQgvR Kz/Wwe6X4JO/7Nd8MApzWwtq/khgfFGTokVo/f+qhNGrg35qaNb/29TUrx4aavZk3HRPFHniY bNL3SZM8/5Ufuv2bnvyk004VLOCh4zukkag6T01DBPcGeWnlJgA0Fyj8gyotohbUrwGkli9ue UYCE3e8ELLlOWECoQqdwy0O2bPezOWjpkCV0CyJAmJhBxRdJUxugx3BgMdNea1n3lbj+gs45p dy+QXpi2J74/50s+e6Qy3s46QfeDm5TW/sT6PxP/k2SdzGBpFC/gqc/PNFcpF5LmFF2Miw1Oa 9laTndR32MpTJtjER3qzL6xhK6IGuCgy6beT2Po0dkOIUK9qClQwSfEjmDH4/iiSBmX7hGtTe 3EvpihVH/LHdvHSofnJczbMbb4gTEQF9MN+W7k9HgFfQpoEPu1UFf/E3YkqNp0gKTGm593Vd+ VUDFRQ1pUE2+6VywSQY3KLPSk7hnKv1LN5IXa7WxFQtjHNGlXa/UdXVoGNXSfqGq9YXntC2AT 8+aF379Zz2Q19E9QgRp8nTXRf6Bv8plGQbMgTojRQF2guvAa2RsqCH28IEiX+QdYHSPjX70Qk KhWRczS6etA8IN1+k4RFvCKKTILULu76jbUbfPcbAaSwrvKGRvYUsMCd8ttIH107gdoZYS489 b5U3ApFbDLnwg/V6TYofVtNM/Kr/X9Nk2+rWNhgGN+VRTVfoxQb/xfOtKkELO/66k98iC60YK zMdFT2LiZhHeEU2wQFkhL+E6hZ4DNx7gGa4NhTBkCWu5qQ11TyGrY/cSXTg5IVWqRsiQAeLEO fizrJZyekhy+Lmm2WFzBdCNfVH/556ViueXmCTo+4PxeYCs37oNoTpQinOZbt5tAYqqMULFTH bYMA7xOmql3D/Dr4KPa920v5OF6aKkHnP7jkiObBaJ13uhmhHHNv0aAtm71bMUtw5pQ4a2o9f pHp/ky9ExSYp5WNNQFVONSDHTZ1WkdTcxvmG4TlQAcxv+fUKoJNzuAsdXqJHbn4gzB3B4ym08 MP3JGm6qrePqZxbcNxYuEL3Ccw5F9zjJ2sidGYvudp17cNtj7qK1GN3PG513imoV6psfmo4lG 0ymPRwQa7ftLNmyV8oo41MZ63YhE4LaMyDjuVwWnUfkZZCae0Yvt3u5zrpVHIvbh+8rs9TVBT MBhbcHClemmZA6Vb6972EsdlYAlK9Kq6S1S9TJUchSsV15PUh5JU+rSCpoZMTI6UJkB8Yan2t buZz7zJIPmfs8dT+6PZqIekSp72TQI9UpHpqNWkjqmY45g4cdcaBsO/lAJEXbpmrqCCDLYtmS 9bNAnDnybmcBapgcrM0YMoBkvOJ0LfelsJxEOEhgMq73MDXHSB7zUnsBkXmrccY8RX2lt64vN KaGhOuwhFJpKmkwOqmGzdqbvUOrEHvP2/6WLHHN9QEp6x7XY0MEIiPk8LsGUvPtaWQ9wcQ+ad NLnfNIwc+tcl8wrllj4HSq+Uc5z12sgmbs1ISyaWkFT5Xd2pbq4ta1yUHlQ/I6WFory3VIul7 VnTO0gpoTtfqhrZm4Pa0yxjAFSbMMgzEFyU/GW3yM7qvdOvxiqx9RfwKUuxbnp+6FReP6Xgkv a80oQcSvW0gIuJRLLGWY1jQ/YKAp3PpblcUAJZLxKvoIIZnH1kst56QmgYdJnzri8WhNr3vWm PlmsoslNfYLxHVmZG1CZm4JOmCRP3v92HADU94xSbKPfD3ZmOMYq5pbQ8Jnj2NoIA5YyeCask 9J2gikmt5XtfFARZb5fLZLWIuvv3y9b/qhhSEDoW5C9TauDM2vhCM8KuCvxzavMv2IJz47ZX3 SHoVuT/zDc2fgaNAFtkqWzarKBGpOiX4ZmFUIgA8o8LmgFT7tc6Qo2+S93ubJkbhcDiHP0S7j a+PvEzeRFid5at5JYVPOqAODnLMGwQAgIOCp4o9dfvO/PLr1TrwVXMVgaY0o7ol59N5roieOE TILLsOXwgCtLlMFHYUvbRkNeXaDM02EmuhUZzbn0UeeZ+sIlZVu4QAwcG7UVazJXZrWtWMx2B bTtoRfnAopPd1fpC16wQOfWJHI7TJqROxGMTkj4otW1peen37umljqhL6SDXqgMSU5+fsKlP2 DWifTDMeH1imBS8iFMTgZGdG0r3jkeNRuYd7SigEH6Q0xSR/ZGANBHoqHbtSzcZ+d6lDXYXd+ 0y/u+AIaY2btYIrnkbEusgHlbAVLSUYRmb0xOqQP+pHWqjy1EUmF+QyFhH2utKl9w8qV2FLCu hEoMdUhHqCZVbxP3rAHGbdG/VeJXMNnGh0gqGBZp0uE4lvQ8R2ID2UCEP856Qx+0DNfYpkZcV a42LHLo0Ye7BE5PiqzNoOC+HxYAEqnW+Cwj3+JB7Cgb92cdEAImsUqkSDN+zRU6Jw5/Pkc4Lm io7jF8RiSECmBDOYO7l1zTcJd5Ee3y X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------5cQMDjeTKlQjOIcJLJwTVeVM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable |Hi |Kevin, Thanks for taking the time to review the patch. |You are right that a hardcoded 4 is perfect for the 16-bit Z80=20 (covering two pushed register pairs), but it would fall short for the=20 eZ80 ADL mode where two pushed registers take up six bytes. Making the=20 limit dependent on the architecture's address width is a reasonable=20 solution. Since `addr_len` is already available in the function, I will=20 change it to `2 * addr_len`. What do you think? I will update the=20 comments as you suggested: 1. Mentioned conditional CALLs alongside the=20 unconditional ones. 2. Updated the old "overflow" comment inside the=20 break block to accurately reflect both exit conditions. Best regards, Rona= ld| --------------5cQMDjeTKlQjOIcJLJwTVeVM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 
Hi Kev=
in,

Thanks for taking the time to review the patch.
You are right=
 that a hardcoded 4 is perfect for the 16-bit Z80
(covering two pushed register pairs), but it would fall short for the eZ80=
 ADL
mode where two pushed registers take up six bytes.=20
Making the limit dependent on the architecture's address width is a reason=
able
solution. Since `addr_len` is already available in the function, I will ch=
ange
it to `2 * addr_len`. What do you think?

I will update the comments as you suggested:
1. Mentioned conditional CALLs alongside the unconditional ones.
2. Updated the old "overflow" comment inside the break block to accurately
   reflect both exit conditions.

Best regards,
Ronald
--------------5cQMDjeTKlQjOIcJLJwTVeVM--