From: Simon Marchi <simon.marchi@polymtl.ca>
To: Gareth McMullin <gareth@blacksphere.co.nz>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PR remote/21188: Fix remote serial timeout
Date: Tue, 14 Mar 2017 01:40:00 -0000 [thread overview]
Message-ID: <c50f945c6be741b872e3d61bdf124faf@polymtl.ca> (raw)
In-Reply-To: <CAL8qUbp4U+4=0CyBC+mfLAOusr+sL2NPOgqyGqo519x5GPHwpw@mail.gmail.com>
On 2017-03-13 21:02, Gareth McMullin wrote:
> Thank you, Simon. I only made the smallest change needed to fix the
> problem. I've attached an updated patch
> to replace the timeout_remaining field with a local variable, and
> remove the unused current_timeout field.
Thanks for the updated patch. I just gave it a quick look, and it looks
good functionally. Just a little formatting issue. The four lines:
else if (timeout_remaining < 0)
continue;
else
return SERIAL_TIMEOUT;
should have one less indent (shift them two spaces to the left).
next prev parent reply other threads:[~2017-03-14 1:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 22:52 Gareth McMullin
2017-03-01 21:52 ` Gareth McMullin
2017-03-02 16:15 ` Simon Marchi
2017-03-14 1:02 ` Gareth McMullin
2017-03-14 1:40 ` Simon Marchi [this message]
2017-03-14 2:13 ` Gareth McMullin
2017-03-14 14:29 ` Pedro Alves
2017-03-17 16:26 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50f945c6be741b872e3d61bdf124faf@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox