From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57324 invoked by alias); 14 Mar 2017 01:40:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57233 invoked by uid 89); 14 Mar 2017 01:40:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Mar 2017 01:40:36 +0000 Received: by simark.ca (Postfix, from userid 33) id 117C71E165; Mon, 13 Mar 2017 21:40:36 -0400 (EDT) To: Gareth McMullin Subject: Re: [PATCH] PR remote/21188: Fix remote serial timeout X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 14 Mar 2017 01:40:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: References: <630aafbb-8684-5aea-0fa1-f0f538b4eb02@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00215.txt.bz2 On 2017-03-13 21:02, Gareth McMullin wrote: > Thank you, Simon. I only made the smallest change needed to fix the > problem. I've attached an updated patch > to replace the timeout_remaining field with a local variable, and > remove the unused current_timeout field. Thanks for the updated patch. I just gave it a quick look, and it looks good functionally. Just a little formatting issue. The four lines: else if (timeout_remaining < 0) continue; else return SERIAL_TIMEOUT; should have one less indent (shift them two spaces to the left).