From: Gareth McMullin <gareth@blacksphere.co.nz>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] PR remote/21188: Fix remote serial timeout
Date: Wed, 01 Mar 2017 21:52:00 -0000 [thread overview]
Message-ID: <CAL8qUbrzyLZHri0jg=-u5xBhv5p9pcX0NZfTeimdSq3iUg5Vag@mail.gmail.com> (raw)
In-Reply-To: <CAL8qUbq2+mJ5OgqTmodR_g4tmQqPGYC_50W4zSBgH9N1Xnje8A@mail.gmail.com>
Ping
On Tue, Feb 21, 2017 at 11:52 AM, Gareth McMullin
<gareth@blacksphere.co.nz> wrote:
> The timeout mechanism in ser-unix.c was changed in commit 048094acc.
>
> In do_hardwire_readchar(), the required timeout is broken into 1
> second intervals and wait_for() is called. Before, wait_for() set
> VTIME and VMIN so the read would block, but now it uses select() to
> block for the specified timeout. If wait_for() returns
> SERIAL_TIMEOUT, do_hardwire_readchar() returns immediately, so the
> timeout is always only 1s.
>
> The attached patch will repeatedly call wait_for() until the full
> timeout has elapsed.
>
> Gareth
--
Black Sphere Technologies Ltd.
Web: www.blacksphere.co.nz
Mobile: +64 27 777 2182
Tel: +64 9 478 8885
Skype: gareth.mcmullin
LinkedIn: http://nz.linkedin.com/in/gsmcmullin
next prev parent reply other threads:[~2017-03-01 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 22:52 Gareth McMullin
2017-03-01 21:52 ` Gareth McMullin [this message]
2017-03-02 16:15 ` Simon Marchi
2017-03-14 1:02 ` Gareth McMullin
2017-03-14 1:40 ` Simon Marchi
2017-03-14 2:13 ` Gareth McMullin
2017-03-14 14:29 ` Pedro Alves
2017-03-17 16:26 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL8qUbrzyLZHri0jg=-u5xBhv5p9pcX0NZfTeimdSq3iUg5Vag@mail.gmail.com' \
--to=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox