From: Simon Marchi <simon.marchi@polymtl.ca>
To: Ambrogino Modigliani <ambrogino.modigliani@gmail.com>
Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt
Subject: Re: [PATCH 03/20] Fix spelling mistakes in comments in makefiles
Date: Sun, 20 Nov 2016 16:53:00 -0000 [thread overview]
Message-ID: <c198d5d280d873e5ef0b13fe3f519805@polymtl.ca> (raw)
In-Reply-To: <1479654381-20698-4-git-send-email-ambrogino.modigliani@mail.com>
On 2016-11-20 10:06, Ambrogino Modigliani wrote:
> gas/ChangeLog:
>
> * gas/Makefile.am: Fix spelling in comments.
> * gas/Makefile.in: Fix spelling in comments.
This is almost nit-picking, since the end result is the same, but I'll
say it just to be sure you know about it. This particular "Makefile.in"
is generated from "Makefile.am" using automake-1.11 (as seen in the
header of Makefile.in). Just like with the "configure" scripts, you
should not edit "Makefile.in" directly. You first edit "Makefile.am"
and run automake-1.11 to generate "Makefile.in" (again, some
distributions still package automake 1.11). Then, your ChangeLog entry
can look like:
gas/ChangeLog:
* Makefile.am: Fix spelling in comments.
* Makefile.in: Re-generate.
When there's a "Makefile.in" without a "Makefile.am", it means that this
one is written by hand, so it's okay to edit it directly.
Another point, which I think applies to all of your patches, is that
your ChangeLog entries should be relative to the location of the
ChangeLog they belong in. For example, since this entry goes in
"gas/ChangeLog", the entry referring to "gas/Makefile.am" should not be:
* gas/Makefile.am: Fix spelling in comments.
but:
* Makefile.am: Fix spelling in comments.
Thanks,
Simon
next prev parent reply other threads:[~2016-11-20 16:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 15:06 [PATCH 00/20] Fix spelling mistakes in comments Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 11/20] Fix spelling mistakes in comments in .em files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 08/20] Fix spelling mistakes in comments in XML files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 14/20] Fix spelling mistakes in comments in .inc files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 10/20] Fix spelling mistakes in comments in .def files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 19/20] Fix spelling mistakes in comments in .tbl files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 17/20] Fix spelling mistakes in comments in .opc files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 18/20] Fix spelling mistakes in comments in .sc files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 12/20] Fix spelling mistakes in comments in .igen files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 13/20] Fix spelling mistakes in comments in .in files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 07/20] Fix spelling mistakes in comments in Expect scripts Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 16/20] Fix spelling mistakes in comments in .m4 files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 02/20] Fix spelling mistakes in comments in configure scripts Ambrogino Modigliani
2016-11-20 16:36 ` Simon Marchi
2016-11-20 15:07 ` [PATCH 20/20] Fix spelling mistakes in comments in .y files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 05/20] Fix spelling mistakes in comments in Ada source files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 15/20] Fix spelling mistakes in comments in .l files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 03/20] Fix spelling mistakes in comments in makefiles Ambrogino Modigliani
2016-11-20 16:53 ` Simon Marchi [this message]
2016-11-20 15:07 ` [PATCH 09/20] Fix spelling mistakes in comments in .cpu files Ambrogino Modigliani
2016-11-20 15:07 ` [PATCH 06/20] Fix spelling mistakes in comments in Assembler files Ambrogino Modigliani
2016-11-20 16:59 ` Simon Marchi
2016-11-20 15:07 ` [PATCH 04/20] Fix spelling mistakes in comments in shell scripts Ambrogino Modigliani
2016-11-20 17:30 ` [PATCH 00/20] Fix spelling mistakes in comments Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c198d5d280d873e5ef0b13fe3f519805@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=ambrogino.modigliani@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox