From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87638 invoked by alias); 20 Nov 2016 16:53:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87620 invoked by uid 89); 20 Nov 2016 16:53:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=automake111, ambrogino, modigliani, Modigliani X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Nov 2016 16:53:31 +0000 Received: by simark.ca (Postfix, from userid 33) id 3985E1E851; Sun, 20 Nov 2016 11:53:30 -0500 (EST) To: Ambrogino Modigliani Subject: Re: [PATCH 03/20] Fix spelling mistakes in comments in makefiles X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 20 Nov 2016 16:53:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt In-Reply-To: <1479654381-20698-4-git-send-email-ambrogino.modigliani@mail.com> References: <1479654381-20698-1-git-send-email-ambrogino.modigliani@mail.com> <1479654381-20698-4-git-send-email-ambrogino.modigliani@mail.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00556.txt.bz2 On 2016-11-20 10:06, Ambrogino Modigliani wrote: > gas/ChangeLog: > > * gas/Makefile.am: Fix spelling in comments. > * gas/Makefile.in: Fix spelling in comments. This is almost nit-picking, since the end result is the same, but I'll say it just to be sure you know about it. This particular "Makefile.in" is generated from "Makefile.am" using automake-1.11 (as seen in the header of Makefile.in). Just like with the "configure" scripts, you should not edit "Makefile.in" directly. You first edit "Makefile.am" and run automake-1.11 to generate "Makefile.in" (again, some distributions still package automake 1.11). Then, your ChangeLog entry can look like: gas/ChangeLog: * Makefile.am: Fix spelling in comments. * Makefile.in: Re-generate. When there's a "Makefile.in" without a "Makefile.am", it means that this one is written by hand, so it's okay to edit it directly. Another point, which I think applies to all of your patches, is that your ChangeLog entries should be relative to the location of the ChangeLog they belong in. For example, since this entry goes in "gas/ChangeLog", the entry referring to "gas/Makefile.am" should not be: * gas/Makefile.am: Fix spelling in comments. but: * Makefile.am: Fix spelling in comments. Thanks, Simon