Re: [PATCH 00/20] Fix spelling mistakes in comments

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2016-11-20 10:06, Ambrogino Modigliani wrote:
> This series fixes number of spelling mistakes in comments in source 
> code
> files in various languages.
> 
> Vast majority of mistakes were discovered by a tool, however each 
> mistake
> is manually checked.
> 
> Ambrogino Modigliani (20):
>   Fix spelling mistakes in comments in C source files
>   Fix spelling mistakes in comments in configure scripts
>   Fix spelling mistakes in comments in makefiles
>   Fix spelling mistakes in comments in shell scripts
>   Fix spelling mistakes in comments in Ada source files
>   Fix spelling mistakes in comments in Assembler files
>   Fix spelling mistakes in comments in Expect scripts
>   Fix spelling mistakes in comments in XML files
>   Fix spelling mistakes in comments in .cpu files
>   Fix spelling mistakes in comments in .def files
>   Fix spelling mistakes in comments in .em files
>   Fix spelling mistakes in comments in .igen files
>   Fix spelling mistakes in comments in .in files
>   Fix spelling mistakes in comments in .inc files
>   Fix spelling mistakes in comments in .l files
>   Fix spelling mistakes in comments in .m4 files
>   Fix spelling mistakes in comments in .opc files
>   Fix spelling mistakes in comments in .sc files
>   Fix spelling mistakes in comments in .tbl files
>   Fix spelling mistakes in comments in .y files

Hi Ambrogino,

Thank you very much for doing this.  I often stumble on small 
typos/spelling mistakes and think I should fix them, but never get 
around to do it.  I'm really glad you took the time.

I didn't look at all the individual fixes, but in general it looks 
great.  It seems like patch 01/20 didn't go through the mailing list 
though.  Sometimes the list rejects patches because they are too big.  
Did you receive a bounce mail from sourceware.org?  If not, you could 
try re-sending this patch by itself...

On top of the comments in the patch themselves, I have two here:

- You sent the patch to the gdb-patches@sourceware.org mailing list, but 
it includes changes in other directories as well.  You should add the 
binutils@sourceware.org list as well, at least.  I don't know if there 
are other relevant lists for other sub-projects, I'll let other people 
clarify this.
- You made fixes to the zlib directory.  I think this is a direct copy 
from the zlib project source code.  It doesn't hurt to fix the mistakes 
in our tree, but it would be more relevant to fix them in the upstream 
project as well.  Otherwise, your changes will be lost the next time we 
import code from zlib.  It might be the same with the readline directory 
and some others, I am not sure.  Others will be able to clarify this.

Thanks,

Simon