From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53395 invoked by alias); 20 Nov 2016 17:30:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53268 invoked by uid 89); 20 Nov 2016 17:30:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=bounce, ambrogino, modigliani, Ambrogino X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Nov 2016 17:30:00 +0000 Received: by simark.ca (Postfix, from userid 33) id 4661A1E851; Sun, 20 Nov 2016 12:29:59 -0500 (EST) To: Ambrogino Modigliani Subject: Re: [PATCH 00/20] Fix spelling mistakes in comments X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 20 Nov 2016 17:30:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt In-Reply-To: <1479654381-20698-1-git-send-email-ambrogino.modigliani@mail.com> References: <1479654381-20698-1-git-send-email-ambrogino.modigliani@mail.com> Message-ID: <881457a649d101c2e1c020ad08d0071e@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00558.txt.bz2 On 2016-11-20 10:06, Ambrogino Modigliani wrote: > This series fixes number of spelling mistakes in comments in source > code > files in various languages. > > Vast majority of mistakes were discovered by a tool, however each > mistake > is manually checked. > > Ambrogino Modigliani (20): > Fix spelling mistakes in comments in C source files > Fix spelling mistakes in comments in configure scripts > Fix spelling mistakes in comments in makefiles > Fix spelling mistakes in comments in shell scripts > Fix spelling mistakes in comments in Ada source files > Fix spelling mistakes in comments in Assembler files > Fix spelling mistakes in comments in Expect scripts > Fix spelling mistakes in comments in XML files > Fix spelling mistakes in comments in .cpu files > Fix spelling mistakes in comments in .def files > Fix spelling mistakes in comments in .em files > Fix spelling mistakes in comments in .igen files > Fix spelling mistakes in comments in .in files > Fix spelling mistakes in comments in .inc files > Fix spelling mistakes in comments in .l files > Fix spelling mistakes in comments in .m4 files > Fix spelling mistakes in comments in .opc files > Fix spelling mistakes in comments in .sc files > Fix spelling mistakes in comments in .tbl files > Fix spelling mistakes in comments in .y files Hi Ambrogino, Thank you very much for doing this. I often stumble on small typos/spelling mistakes and think I should fix them, but never get around to do it. I'm really glad you took the time. I didn't look at all the individual fixes, but in general it looks great. It seems like patch 01/20 didn't go through the mailing list though. Sometimes the list rejects patches because they are too big. Did you receive a bounce mail from sourceware.org? If not, you could try re-sending this patch by itself... On top of the comments in the patch themselves, I have two here: - You sent the patch to the gdb-patches@sourceware.org mailing list, but it includes changes in other directories as well. You should add the binutils@sourceware.org list as well, at least. I don't know if there are other relevant lists for other sub-projects, I'll let other people clarify this. - You made fixes to the zlib directory. I think this is a direct copy from the zlib project source code. It doesn't hurt to fix the mistakes in our tree, but it would be more relevant to fix them in the upstream project as well. Otherwise, your changes will be lost the next time we import code from zlib. It might be the same with the readline directory and some others, I am not sure. Others will be able to clarify this. Thanks, Simon