From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands
Date: Mon, 04 Sep 2017 17:16:00 -0000 [thread overview]
Message-ID: <c0a97397d7db3835265528cf817a4e29@polymtl.ca> (raw)
In-Reply-To: <3fad43f4-0969-4d11-a361-1ba48d856c2e@redhat.com>
On 2017-09-04 14:36, Pedro Alves wrote:
> On 09/02/2017 10:36 PM, Simon Marchi wrote:
>> I grepped the testsuite for loop_break and loop_continue and didn't
>> find
>> anything, so I wrote some simple tests for those.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.base/commands.exp: Call the new procedures.
>> (loop_break_test, loop_continue_test): New procedures.
>
> LGTM, please push, and thanks for doing this.
>
> I do wonder whether we handle loop_break/loop_continue in nested
> loops correctly though, since the tests don't seem to
> exercise that.
>
> Thanks,
> Pedro Alves
Ah good point. I am pushing this one, and I'll work on another patch to
test this.
Thanks,
Simon
prev parent reply other threads:[~2017-09-04 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 21:36 [PATCH 0/3] Tiny patches related to command lines Simon Marchi
2017-09-02 21:37 ` [PATCH 2/3] Error out immediatly when using if command without args in command list Simon Marchi
2017-09-04 12:35 ` Pedro Alves
2017-09-04 17:15 ` Simon Marchi
2017-09-02 21:37 ` [PATCH 1/3] Move command lines types/declarations to cli-script.h Simon Marchi
2017-09-04 12:28 ` Pedro Alves
2017-09-02 21:37 ` [PATCH 3/3] Add tests for loop_break and loop_continue commands Simon Marchi
2017-09-04 12:36 ` Pedro Alves
2017-09-04 17:16 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a97397d7db3835265528cf817a4e29@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox