From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Move command lines types/declarations to cli-script.h
Date: Mon, 04 Sep 2017 12:28:00 -0000 [thread overview]
Message-ID: <a7946a05-018d-3407-cef4-40354abd37d8@redhat.com> (raw)
In-Reply-To: <1504388179-579-2-git-send-email-simon.marchi@ericsson.com>
On 09/02/2017 10:36 PM, Simon Marchi wrote:
> I think it would make more sense if the types and function declarations
> related to command lines were in cli-script.h rather than defs.h, since
> the related function definitions are in cli-script.c.
>
> I had to add a few includes here and there. I also had to rename the
> "lines" parameter of command_lines_deleter::operator(), because ncurses
> has a "#define lines ..." that was interfering when cli-script.h is
> included by some TUI source files that also include ncurses header files.
LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-09-04 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 21:36 [PATCH 0/3] Tiny patches related to command lines Simon Marchi
2017-09-02 21:37 ` [PATCH 1/3] Move command lines types/declarations to cli-script.h Simon Marchi
2017-09-04 12:28 ` Pedro Alves [this message]
2017-09-02 21:37 ` [PATCH 2/3] Error out immediatly when using if command without args in command list Simon Marchi
2017-09-04 12:35 ` Pedro Alves
2017-09-04 17:15 ` Simon Marchi
2017-09-02 21:37 ` [PATCH 3/3] Add tests for loop_break and loop_continue commands Simon Marchi
2017-09-04 12:36 ` Pedro Alves
2017-09-04 17:16 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7946a05-018d-3407-cef4-40354abd37d8@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox