From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72526 invoked by alias); 4 Sep 2017 17:16:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72511 invoked by uid 89); 4 Sep 2017 17:16:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Sep 2017 17:15:56 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v84HFnGj022594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 4 Sep 2017 13:15:54 -0400 Received: by simark.ca (Postfix, from userid 112) id BC0CC1EA26; Mon, 4 Sep 2017 13:15:49 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 49ED51E974; Mon, 4 Sep 2017 13:15:49 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 Sep 2017 17:16:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands In-Reply-To: <3fad43f4-0969-4d11-a361-1ba48d856c2e@redhat.com> References: <1504388179-579-1-git-send-email-simon.marchi@ericsson.com> <1504388179-579-4-git-send-email-simon.marchi@ericsson.com> <3fad43f4-0969-4d11-a361-1ba48d856c2e@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 4 Sep 2017 17:15:49 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00059.txt.bz2 On 2017-09-04 14:36, Pedro Alves wrote: > On 09/02/2017 10:36 PM, Simon Marchi wrote: >> I grepped the testsuite for loop_break and loop_continue and didn't >> find >> anything, so I wrote some simple tests for those. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.base/commands.exp: Call the new procedures. >> (loop_break_test, loop_continue_test): New procedures. > > LGTM, please push, and thanks for doing this. > > I do wonder whether we handle loop_break/loop_continue in nested > loops correctly though, since the tests don't seem to > exercise that. > > Thanks, > Pedro Alves Ah good point. I am pushing this one, and I'll work on another patch to test this. Thanks, Simon