Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206)

[Wei-min Pan <weimin.pan@oracle.com>]

Hi Rainer,


On 9/27/2017 2:16 AM, Rainer Orth wrote:
> Hi Wei-min,
>
>> On 9/26/2017 6:02 AM, Rainer Orth wrote:
>>> Hi Pedro,
>>>
>>>> On 09/26/2017 10:33 AM, Rainer Orth wrote:
>>>>
>>>>> Apart from the capitalization differences that trip g++, the names
>>>>> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV,
>>>>> and there's no PSR_V8PLUS on Solaris either.
>>>> What you've done is fine with me to unbreak the build.  Though
>>>> I'd prefer if we renamed those to avoid ever relying on host
>>>> symbols, anywhere.  Like:
>>>>
>>>>    - #define PSR_S ...
>>>>    + #define SPARC64_PSR_S ...
>>>>
>>>> etc.
>>> agreed.  That's probably best done when figuring out how to properly
>>> separate target-dependent and independent parts of ADI support.
>>>
>>> 	Rainer
>>>
>> Macros PSR_ICC/PSR_IMPL are not parts of ADI and were added to
>> sparc64-tdep.c
>> long before the Linux ADI project. Still trying to figure out why these two
>> macros,
>> pulled from /usr/include/v7/sys/psr.h, are causing problems now.
> I suspect there were changes to gdb/defs.h, gdb/common/common-defs.h or
> gnulib that ultimately dragged that file in post gdb-8.1.  Seems I've
> been barking up the wrong tree for this one, sorry.
>
> Even so, the other problems with the ADI implemention mentioned both in
> the patch submission and the PR are certainly new.
>
> 	Rainer
>

Thanks for tracking down the marco problem.

As for the issues you raised on gdb ADI support for Solaris/SPARC in the 
bug report,
it's never intended to add that support for Solaris. While that Solaris 
provided a totally
different ADI API was a factor, for example, Linux made the information 
of ADI block
size available in the ELF aux record, one needed to make a syscall on 
Solaris to get that
piece of information, it's certainly doable.  It was never planned, 
however, and most likely
will never be.