From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80757 invoked by alias); 27 Sep 2017 20:43:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80260 invoked by uid 89); 27 Sep 2017 20:43:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:4300 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Sep 2017 20:43:28 +0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v8RKhK9O025425 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Sep 2017 20:43:21 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v8RKhKsu032683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Sep 2017 20:43:20 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v8RKhGJU005786; Wed, 27 Sep 2017 20:43:16 GMT Received: from [10.159.133.47] (/10.159.133.47) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Sep 2017 13:43:16 -0700 Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) To: Rainer Orth Cc: Pedro Alves , gdb-patches@sourceware.org References: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> From: Wei-min Pan Message-ID: Date: Wed, 27 Sep 2017 20:43:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00841.txt.bz2 Hi Rainer, On 9/27/2017 2:16 AM, Rainer Orth wrote: > Hi Wei-min, > >> On 9/26/2017 6:02 AM, Rainer Orth wrote: >>> Hi Pedro, >>> >>>> On 09/26/2017 10:33 AM, Rainer Orth wrote: >>>> >>>>> Apart from the capitalization differences that trip g++, the names >>>>> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV, >>>>> and there's no PSR_V8PLUS on Solaris either. >>>> What you've done is fine with me to unbreak the build. Though >>>> I'd prefer if we renamed those to avoid ever relying on host >>>> symbols, anywhere. Like: >>>> >>>> - #define PSR_S ... >>>> + #define SPARC64_PSR_S ... >>>> >>>> etc. >>> agreed. That's probably best done when figuring out how to properly >>> separate target-dependent and independent parts of ADI support. >>> >>> Rainer >>> >> Macros PSR_ICC/PSR_IMPL are not parts of ADI and were added to >> sparc64-tdep.c >> long before the Linux ADI project. Still trying to figure out why these two >> macros, >> pulled from /usr/include/v7/sys/psr.h, are causing problems now. > I suspect there were changes to gdb/defs.h, gdb/common/common-defs.h or > gnulib that ultimately dragged that file in post gdb-8.1. Seems I've > been barking up the wrong tree for this one, sorry. > > Even so, the other problems with the ADI implemention mentioned both in > the patch submission and the PR are certainly new. > > Rainer > Thanks for tracking down the marco problem. As for the issues you raised on gdb ADI support for Solaris/SPARC in the bug report, it's never intended to add that support for Solaris. While that Solaris provided a totally different ADI API was a factor, for example, Linux made the information of ADI block size available in the ELF aux record, one needed to make a syscall on Solaris to get that piece of information, it's certainly doable.  It was never planned, however, and most likely will never be.