From: Wei-min Pan <weimin.pan@oracle.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206)
Date: Tue, 26 Sep 2017 16:06:00 -0000 [thread overview]
Message-ID: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> (raw)
In-Reply-To: <yddo9pxvcin.fsf@CeBiTec.Uni-Bielefeld.DE>
On 9/26/2017 6:02 AM, Rainer Orth wrote:
> Hi Pedro,
>
>> On 09/26/2017 10:33 AM, Rainer Orth wrote:
>>
>>> Apart from the capitalization differences that trip g++, the names
>>> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV,
>>> and there's no PSR_V8PLUS on Solaris either.
>> What you've done is fine with me to unbreak the build. Though
>> I'd prefer if we renamed those to avoid ever relying on host
>> symbols, anywhere. Like:
>>
>> - #define PSR_S ...
>> + #define SPARC64_PSR_S ...
>>
>> etc.
> agreed. That's probably best done when figuring out how to properly
> separate target-dependent and independent parts of ADI support.
>
> Rainer
>
Macros PSR_ICC/PSR_IMPL are not parts of ADI and were added to
sparc64-tdep.c
long before the Linux ADI project. Still trying to figure out why these
two macros,
pulled from /usr/include/v7/sys/psr.h, are causing problems now.
next prev parent reply other threads:[~2017-09-26 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:33 Rainer Orth
2017-09-26 11:33 ` Pedro Alves
2017-09-26 13:04 ` Rainer Orth
2017-09-26 16:06 ` Wei-min Pan [this message]
2017-09-27 9:16 ` Rainer Orth
2017-09-27 20:43 ` Wei-min Pan
2017-09-28 12:40 ` Rainer Orth
2017-09-28 14:19 ` Pedro Alves
2017-09-28 14:37 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com \
--to=weimin.pan@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox