From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126065 invoked by alias); 26 Sep 2017 16:06:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126035 invoked by uid 89); 26 Sep 2017 16:06:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 16:06:35 +0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v8QG6ScK006615 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Sep 2017 16:06:29 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v8QG6StL028371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Sep 2017 16:06:28 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v8QG6NL4029330; Tue, 26 Sep 2017 16:06:23 GMT Received: from [10.159.247.45] (/10.159.247.45) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Sep 2017 09:06:23 -0700 Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) To: Rainer Orth , Pedro Alves Cc: gdb-patches@sourceware.org References: From: Wei-min Pan Message-ID: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> Date: Tue, 26 Sep 2017 16:06:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00807.txt.bz2 On 9/26/2017 6:02 AM, Rainer Orth wrote: > Hi Pedro, > >> On 09/26/2017 10:33 AM, Rainer Orth wrote: >> >>> Apart from the capitalization differences that trip g++, the names >>> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV, >>> and there's no PSR_V8PLUS on Solaris either. >> What you've done is fine with me to unbreak the build. Though >> I'd prefer if we renamed those to avoid ever relying on host >> symbols, anywhere. Like: >> >> - #define PSR_S ... >> + #define SPARC64_PSR_S ... >> >> etc. > agreed. That's probably best done when figuring out how to properly > separate target-dependent and independent parts of ADI support. > > Rainer > Macros PSR_ICC/PSR_IMPL are not parts of ADI and were added to sparc64-tdep.c long before the Linux ADI project. Still trying to figure out why these two macros, pulled from /usr/include/v7/sys/psr.h, are causing problems now.