From: Kamil Rytarowski <kamil@netbsd.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver
Date: Fri, 18 Sep 2020 19:41:02 +0200 [thread overview]
Message-ID: <bda96b5f-055e-8522-6a12-305e7746e480@netbsd.org> (raw)
In-Reply-To: <874knxaema.fsf@tromey.com>
[-- Attachment #1.1: Type: text/plain, Size: 1207 bytes --]
On 16.09.2020 18:08, Tom Tromey wrote:
>>>>>> "Kamil" == Kamil Rytarowski <n54@gmx.com> writes:
>
> While switching the target wait flags to be a flag enum type, I found a
> small problem in the new NetBSD gdbserver work.
>
> Kamil> +/* Implement a safe wrapper around waitpid(). */
> Kamil> +
> Kamil> +static pid_t
> Kamil> +netbsd_waitpid (ptid_t ptid, struct target_waitstatus *ourstatus, int options)
>
> Here options is either 0 or:
>
> #define TARGET_WNOHANG 1
>
> Kamil> +{
> Kamil> + int status;
> Kamil> +
> Kamil> + pid_t pid = gdb::handle_eintr (::waitpid, ptid.pid (), &status, options);
>
> ... but it is passed directly to ::waitpid. This is fine for now if the
> system WNOHANG happens to be 1. However, I think it would be better not
> to rely on this. For one thing, there's no guarantee that the value of
> TARGET_WNOHANG will never change.
>
> Kamil> + pid_t pid = netbsd_waitpid (ptid, ourstatus, target_options);
>
> Here's a spot making the call; this shows that the target option is
> being passed untranslated.
>
I see. It happens that WNOHANG is equal to TARGET_WNOHANG on NetBSD and
it went unnoticed.
> thanks,
> Tom
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-18 17:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 17:59 [PATCH 00/10] Add minimal NetBSD/amd64 gdbserver support Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 01/10] Add handle_eintr to wrap EINTR handling in syscalls Kamil Rytarowski
2020-09-03 14:17 ` Tom Tromey
2020-09-03 21:10 ` Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 02/10] Register a placeholder for NetBSD shared functions in gdb/nat Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 03/10] Build nat/netbsd-nat.o for the NetBSD native target Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 04/10] Add netbsd_nat::pid_to_exec_file Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 05/10] Add gdb/nat common functions for listing threads Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 06/10] Add netbsd_nat::enable_proc_events in gdb/nat Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 07/10] Add a common utility function to read and write siginfo_t in inferior Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 08/10] Avoid double free in startup_inferior Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 09/10] Switch local native code to gdb/nat shared functions Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver Kamil Rytarowski
2020-09-03 17:42 ` Aktemur, Tankut Baris
2020-09-04 0:13 ` Kamil Rytarowski
2020-09-04 7:58 ` Aktemur, Tankut Baris
2020-09-04 12:35 ` Kamil Rytarowski
2020-09-16 16:08 ` Tom Tromey
2020-09-18 17:41 ` Kamil Rytarowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda96b5f-055e-8522-6a12-305e7746e480@netbsd.org \
--to=kamil@netbsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox