From: Kamil Rytarowski <kamil@netbsd.org>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
Kamil Rytarowski <kamil@netbsd.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver
Date: Fri, 4 Sep 2020 14:35:10 +0200 [thread overview]
Message-ID: <50e17cc6-5b8a-e4fb-a77d-9e279c8d87c0@netbsd.org> (raw)
In-Reply-To: <BL0PR11MB2882FC710F2B00BD98F4DF3CC42D0@BL0PR11MB2882.namprd11.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
On 04.09.2020 09:58, Aktemur, Tankut Baris via Gdb-patches wrote:
> A final note: I'm not fully knowledgeable in the semantics of all the target ops
> or in NetBSD. Please consider my comments as a general check against the code style
> and smells.
Thanks for the review. I have applied your changes in v2 with a few
exceptions as noted earlier.
This is a simplified code (no FPU support etc) and x86_64 support only.
I'm looking forward to more review notes, especially from people with
approval authority.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-04 12:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 17:59 [PATCH 00/10] Add minimal NetBSD/amd64 gdbserver support Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 01/10] Add handle_eintr to wrap EINTR handling in syscalls Kamil Rytarowski
2020-09-03 14:17 ` Tom Tromey
2020-09-03 21:10 ` Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 02/10] Register a placeholder for NetBSD shared functions in gdb/nat Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 03/10] Build nat/netbsd-nat.o for the NetBSD native target Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 04/10] Add netbsd_nat::pid_to_exec_file Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 05/10] Add gdb/nat common functions for listing threads Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 06/10] Add netbsd_nat::enable_proc_events in gdb/nat Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 07/10] Add a common utility function to read and write siginfo_t in inferior Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 08/10] Avoid double free in startup_inferior Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 09/10] Switch local native code to gdb/nat shared functions Kamil Rytarowski
2020-09-02 17:59 ` [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver Kamil Rytarowski
2020-09-03 17:42 ` Aktemur, Tankut Baris
2020-09-04 0:13 ` Kamil Rytarowski
2020-09-04 7:58 ` Aktemur, Tankut Baris
2020-09-04 12:35 ` Kamil Rytarowski [this message]
2020-09-16 16:08 ` Tom Tromey
2020-09-18 17:41 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e17cc6-5b8a-e4fb-a77d-9e279c8d87c0@netbsd.org \
--to=kamil@netbsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox