From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.netbsd.org (mail.NetBSD.org [IPv6:2001:470:a085:999::25]) by sourceware.org (Postfix) with ESMTPS id BCD88386F461 for ; Fri, 4 Sep 2020 12:38:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BCD88386F461 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=netbsd.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kamil@netbsd.org Received: from [IPv6:::1] (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id B25C784CEA; Fri, 4 Sep 2020 12:38:27 +0000 (UTC) Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver To: "Aktemur, Tankut Baris" , Kamil Rytarowski , "gdb-patches@sourceware.org" References: <20200902175926.13182-1-n54@gmx.com> <20200902175926.13182-11-n54@gmx.com> <0faf3e36-bad7-545d-a939-99badc20e5f4@netbsd.org> From: Kamil Rytarowski Autocrypt: addr=kamil@netbsd.org; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCNLYW1pbCBSeXRh cm93c2tpIDxrYW1pbEBOZXRCU0Qub3JnPokCOQQTAQgAIwUCVbKF6wIbIwcLCQgHAwIBBhUI AgkKCwQWAgMBAh4BAheAAAoJEEuzCOmwLnZsrgwQAMdXTXDWkxtUciFgBnioE6hvZYOBV7Xa Gh3dwgVvS5rLwwq5ob1R9qdtCGMYxdaCAQCzo2hhUfe9ts11/Q4Pg0aDAb5CfdVVTmyvLMu+ gtK99t/sG4SfCdn8Bb8rCfRRDpkTq1cAGy6pp7rxyMrFBITTbdBWVcWdEdlMhEZtV8Z1BNDI kwEwZkYnM1UxOGW4rJNjNU+hBjNAscCTwBSbpG6NV1oBbgmgJ1PfaPCeAmGTLZyI57VLuFJy kR0Jlj8Ui7dAaJgO1WYdmvL+48s0N2QGEoHnrf50xoO34LlrIBUsCLmhtjWhZiuj0meCxNTr 5YpdBP13b2i64OCruH8/M4IO85GAIWxIMMv510rge9qSe38NHCzSmn9zcjFwVXIh9flZi7PK eqOP3yah6r1ZIBY68If/2FtvwDptUi1NHoSpN+dt0kRg26hDqMFOg+Jc6o7Wtm+3vFNDhU4I 8HkjDr62VlbHBxe6gDgVELcecWgXOydKgdrQhOPwCBJkPJigifsIz4EZQnyI3CchFja3qR9J Vo4iXwqAi6xN4RD0PS775JYDh56qUaaUsEctQ/D6Xm7Bbdv1VPlsYs/9uXxc/jWVhkd1sDn2 KZ3kv7uo04DoejVGWK9B4XEZ1ufRPzmlV0SYohX34ouLBq5Q6wbyw6+hUM+yM9RcvgkOCVgB laejuQINBFVwUF8BEAC61vNvzAAcYvkU89YoStDcGyun1ENNWpHOnuQEw613/Xgys6xZbKKa Xhee8Fiwm6FlaiYWh66Vw5cA+hMna9PDp6tZi106JnKZ9DcYxanHOCQ5V42OwUX0BDfwUIwq YgOz12Cf4pdIheVkDfiSEot3XrdI3lT8od9iWeehx5zfW77utVrWGUXkMFJKmiKzxyzjV+gF gLk2wH+L7KoYiV/MfLukLa7mTJAK4mi0sfjLStPlf5gELvPtyooKG0gs0MbDSG2qmzb1/A4Y ET8Vaa7wJulIePym+Du5TJBwptls0KEF9a04kp2Oc2zlUd/Z5z3lLBiZaXpfProbz3Ydjg4O 2+XTn+SHSq10l3agjiAkGwHH83Xnzn/clg3iTvwYgdOcwvfEnJ1FGz3DAzcBd/+IMaszJjuo dBVckt07mc97sseDjy+vIIyQGdMzDmI0U9UK7nDUFpnIfG5LYe+myBS1CgFrZAQ/WNg0j7aq CiIgbhVAOFi2sPRYlph2L8LZRUPFHLTt23vdJXdFDuKM6JSvPiDf914UpjXr/WSwT43lJzlO O3zgKGM7eclFsetDF3p0I4SVHvR7dHbIC5IHibssmk7bQgH0K1aGUX/QC18v3VY7wYYaotYH RnTiGbBGz+XxPhZYiXKQuyFu6dY3qOw/VjbsV6KVNn49z2Zg4RQV8QARAQABiQIfBBgBCAAJ BQJVcFBfAhsMAAoJEEuzCOmwLnZs9rIP/2MTyZ0252u51LFsMHa9/ylTyvl+UKq8iR852lkZ X9bH9nH4cUcen5vZo0EZI3IVOemHUq71u+DTq8PSj5vtJ0DW+sGBEbjW3Q4IjJ+96PPrlemK fYS0KWVwEzzNQLEejjduU43x83DvQ/URzSWgGnhMBqXUyJdsHyTFFNFwQ9U71gX00+wXHJyh aXRlK+7gRKtCWuNFtW/5bQXL9epxDAS0POIVAdBc1FtPLwg08Pj0KwHsGQpEr5/W8ybDtLF+ zISHIKCj1lZ8dv/7D1PmH5SEXzsv+bbzvPtb6zhoIA8HONshaG2eAYknAiCJZ0gj0npgktwc u9VkvDvHMD9+VyNzRV/M6Ak4nDeEG6QecTPv8IqCcAHDI27nY/49BvFVOJOMwqbTp5Xvfa71 ksP1mARrN+bIYMfOy7OhfCxGeZydvBhgCLKdL698aXmgy0xrmrOw+GXO69GVcebOvxWMXxz1 FOG/JnLIe1ZgCo2YF5wy8zTCGKCMx6gAwnku2nJmDGNsePVedV00FmB8mQ7Oxz+3B9+LtFim FHHR33PlRnViXlG+XTm9NontiGE0LvG4TzIY5CYNSw8PBao795dQMSsmMI4FHlvTIgupE9g1 PQWP+2H2C0RtnLUanRNUGRkze1+MNG7jc+fqJIo5s7+PSs26rUvA38QzEOJ95k7hdJty Message-ID: <50e17cc6-5b8a-e4fb-a77d-9e279c8d87c0@netbsd.org> Date: Fri, 4 Sep 2020 14:35:10 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S4Cydvcng4WAFk95aZmuR3VkOg34RyCEr" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 12:38:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --S4Cydvcng4WAFk95aZmuR3VkOg34RyCEr Content-Type: multipart/mixed; boundary="AOXG8nwQGnGrtrXCaL5G4L4i35AfxzmEI"; protected-headers="v1" From: Kamil Rytarowski To: "Aktemur, Tankut Baris" , Kamil Rytarowski , "gdb-patches@sourceware.org" Message-ID: <50e17cc6-5b8a-e4fb-a77d-9e279c8d87c0@netbsd.org> Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver References: <20200902175926.13182-1-n54@gmx.com> <20200902175926.13182-11-n54@gmx.com> <0faf3e36-bad7-545d-a939-99badc20e5f4@netbsd.org> In-Reply-To: --AOXG8nwQGnGrtrXCaL5G4L4i35AfxzmEI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04.09.2020 09:58, Aktemur, Tankut Baris via Gdb-patches wrote: > A final note: I'm not fully knowledgeable in the semantics of all the t= arget ops > or in NetBSD. Please consider my comments as a general check against t= he code style > and smells. Thanks for the review. I have applied your changes in v2 with a few exceptions as noted earlier. This is a simplified code (no FPU support etc) and x86_64 support only. I'm looking forward to more review notes, especially from people with approval authority. --AOXG8nwQGnGrtrXCaL5G4L4i35AfxzmEI-- --S4Cydvcng4WAFk95aZmuR3VkOg34RyCEr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl9SNJwACgkQS7MI6bAu dmyCkxAAn0Lbyk4LNwQryTntCZyAKJo4KvucIuzSMV94qfQi44gidtuj84tt3cAI UXD+VKR7K7HS0mKgAXLVWksMjQEShcAOgYqVwS72mWv0PoILD8BtGV8qa0OTlyQs H3gA9PwZCpVQ2myBUQVPz9l51YR+nAwIRlQm64+/DRPtdXGFL0+2Arr5zwGzXDyN bjGB35Cr9zq7A0xeuUWq6ly7EgOVAzmWPFE9hQmUgn4QVzcVIRSBDVVG1MXgbeX2 9iwO2pcAvIjeU7n7TnbFMA2MzGrZDxRHim8haVZmbiKpEQpz/6IWSOGmqOzTYD/V NLRn0jAR8aqgP7GUBJJm2Xp0DsQuv6DfjVXF2MNjiaolpaBWcVeXV6JXEc/asAbC uIbpmu4tARij85wfsSbBAn2fugqwx1VyH6MkN3mqo4WNwWe99kixykab7FPyozd8 8S8Ql7tAGzjn7PDl1JsNk8UWLZHza6h2qEvpJWxd6tgAmTm+lbQ0GmCuyFUT/1Ul kSu6TcZvPybT0e1XLn3jPolbo9hOYbOXAnmur9yqgOntwv+uguLbOjb0ZEUXtlNX cYyDPeem0wnK9VQvVEWRFB5DTMNoHXs6zujOioGfwvoiUCt/lAlOUQzTWechE7xf +AN6XmbwMHIwGK8mkrLzd1uegDwNYGwxe3MJPJ3UpRDFV7Drp8k= =8w14 -----END PGP SIGNATURE----- --S4Cydvcng4WAFk95aZmuR3VkOg34RyCEr--