From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) by sourceware.org (Postfix) with ESMTPS id 029DF3857C7A for ; Fri, 18 Sep 2020 17:44:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 029DF3857C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=netbsd.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kamil@netbsd.org Received: from [IPv6:::1] (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 48DCF84CDC; Fri, 18 Sep 2020 17:44:05 +0000 (UTC) Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200902175926.13182-1-n54@gmx.com> <20200902175926.13182-11-n54@gmx.com> <874knxaema.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=kamil@netbsd.org; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCNLYW1pbCBSeXRh cm93c2tpIDxrYW1pbEBOZXRCU0Qub3JnPokCOQQTAQgAIwUCVbKF6wIbIwcLCQgHAwIBBhUI AgkKCwQWAgMBAh4BAheAAAoJEEuzCOmwLnZsrgwQAMdXTXDWkxtUciFgBnioE6hvZYOBV7Xa Gh3dwgVvS5rLwwq5ob1R9qdtCGMYxdaCAQCzo2hhUfe9ts11/Q4Pg0aDAb5CfdVVTmyvLMu+ gtK99t/sG4SfCdn8Bb8rCfRRDpkTq1cAGy6pp7rxyMrFBITTbdBWVcWdEdlMhEZtV8Z1BNDI kwEwZkYnM1UxOGW4rJNjNU+hBjNAscCTwBSbpG6NV1oBbgmgJ1PfaPCeAmGTLZyI57VLuFJy kR0Jlj8Ui7dAaJgO1WYdmvL+48s0N2QGEoHnrf50xoO34LlrIBUsCLmhtjWhZiuj0meCxNTr 5YpdBP13b2i64OCruH8/M4IO85GAIWxIMMv510rge9qSe38NHCzSmn9zcjFwVXIh9flZi7PK eqOP3yah6r1ZIBY68If/2FtvwDptUi1NHoSpN+dt0kRg26hDqMFOg+Jc6o7Wtm+3vFNDhU4I 8HkjDr62VlbHBxe6gDgVELcecWgXOydKgdrQhOPwCBJkPJigifsIz4EZQnyI3CchFja3qR9J Vo4iXwqAi6xN4RD0PS775JYDh56qUaaUsEctQ/D6Xm7Bbdv1VPlsYs/9uXxc/jWVhkd1sDn2 KZ3kv7uo04DoejVGWK9B4XEZ1ufRPzmlV0SYohX34ouLBq5Q6wbyw6+hUM+yM9RcvgkOCVgB laejuQINBFVwUF8BEAC61vNvzAAcYvkU89YoStDcGyun1ENNWpHOnuQEw613/Xgys6xZbKKa Xhee8Fiwm6FlaiYWh66Vw5cA+hMna9PDp6tZi106JnKZ9DcYxanHOCQ5V42OwUX0BDfwUIwq YgOz12Cf4pdIheVkDfiSEot3XrdI3lT8od9iWeehx5zfW77utVrWGUXkMFJKmiKzxyzjV+gF gLk2wH+L7KoYiV/MfLukLa7mTJAK4mi0sfjLStPlf5gELvPtyooKG0gs0MbDSG2qmzb1/A4Y ET8Vaa7wJulIePym+Du5TJBwptls0KEF9a04kp2Oc2zlUd/Z5z3lLBiZaXpfProbz3Ydjg4O 2+XTn+SHSq10l3agjiAkGwHH83Xnzn/clg3iTvwYgdOcwvfEnJ1FGz3DAzcBd/+IMaszJjuo dBVckt07mc97sseDjy+vIIyQGdMzDmI0U9UK7nDUFpnIfG5LYe+myBS1CgFrZAQ/WNg0j7aq CiIgbhVAOFi2sPRYlph2L8LZRUPFHLTt23vdJXdFDuKM6JSvPiDf914UpjXr/WSwT43lJzlO O3zgKGM7eclFsetDF3p0I4SVHvR7dHbIC5IHibssmk7bQgH0K1aGUX/QC18v3VY7wYYaotYH RnTiGbBGz+XxPhZYiXKQuyFu6dY3qOw/VjbsV6KVNn49z2Zg4RQV8QARAQABiQIfBBgBCAAJ BQJVcFBfAhsMAAoJEEuzCOmwLnZs9rIP/2MTyZ0252u51LFsMHa9/ylTyvl+UKq8iR852lkZ X9bH9nH4cUcen5vZo0EZI3IVOemHUq71u+DTq8PSj5vtJ0DW+sGBEbjW3Q4IjJ+96PPrlemK fYS0KWVwEzzNQLEejjduU43x83DvQ/URzSWgGnhMBqXUyJdsHyTFFNFwQ9U71gX00+wXHJyh aXRlK+7gRKtCWuNFtW/5bQXL9epxDAS0POIVAdBc1FtPLwg08Pj0KwHsGQpEr5/W8ybDtLF+ zISHIKCj1lZ8dv/7D1PmH5SEXzsv+bbzvPtb6zhoIA8HONshaG2eAYknAiCJZ0gj0npgktwc u9VkvDvHMD9+VyNzRV/M6Ak4nDeEG6QecTPv8IqCcAHDI27nY/49BvFVOJOMwqbTp5Xvfa71 ksP1mARrN+bIYMfOy7OhfCxGeZydvBhgCLKdL698aXmgy0xrmrOw+GXO69GVcebOvxWMXxz1 FOG/JnLIe1ZgCo2YF5wy8zTCGKCMx6gAwnku2nJmDGNsePVedV00FmB8mQ7Oxz+3B9+LtFim FHHR33PlRnViXlG+XTm9NontiGE0LvG4TzIY5CYNSw8PBao795dQMSsmMI4FHlvTIgupE9g1 PQWP+2H2C0RtnLUanRNUGRkze1+MNG7jc+fqJIo5s7+PSs26rUvA38QzEOJ95k7hdJty Message-ID: Date: Fri, 18 Sep 2020 19:41:02 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <874knxaema.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fVFr6D0NqFXFjDHvGbV1D06FjIqIpP8PE" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 17:44:09 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fVFr6D0NqFXFjDHvGbV1D06FjIqIpP8PE Content-Type: multipart/mixed; boundary="ynOG8exwMAJKc3DCBxR8f5MaOD23RO37Y"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: Subject: Re: [PATCH 10/10] Add minimal and functional NetBSD/amd64 gdbserver References: <20200902175926.13182-1-n54@gmx.com> <20200902175926.13182-11-n54@gmx.com> <874knxaema.fsf@tromey.com> In-Reply-To: <874knxaema.fsf@tromey.com> --ynOG8exwMAJKc3DCBxR8f5MaOD23RO37Y Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 16.09.2020 18:08, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: >=20 > While switching the target wait flags to be a flag enum type, I found a= > small problem in the new NetBSD gdbserver work. >=20 > Kamil> +/* Implement a safe wrapper around waitpid(). */ > Kamil> + > Kamil> +static pid_t > Kamil> +netbsd_waitpid (ptid_t ptid, struct target_waitstatus *ourstatu= s, int options) >=20 > Here options is either 0 or: >=20 > #define TARGET_WNOHANG 1 >=20 > Kamil> +{ > Kamil> + int status; > Kamil> + > Kamil> + pid_t pid =3D gdb::handle_eintr (::waitpid, ptid.pid (), &sta= tus, options); >=20 > ... but it is passed directly to ::waitpid. This is fine for now if th= e > system WNOHANG happens to be 1. However, I think it would be better no= t > to rely on this. For one thing, there's no guarantee that the value of= > TARGET_WNOHANG will never change. >=20 > Kamil> + pid_t pid =3D netbsd_waitpid (ptid, ourstatus, target_options= ); >=20 > Here's a spot making the call; this shows that the target option is > being passed untranslated. >=20 I see. It happens that WNOHANG is equal to TARGET_WNOHANG on NetBSD and it went unnoticed. > thanks, > Tom >=20 --ynOG8exwMAJKc3DCBxR8f5MaOD23RO37Y-- --fVFr6D0NqFXFjDHvGbV1D06FjIqIpP8PE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl9k8TYACgkQS7MI6bAu dmwhNA/+M0wEWqiXzmY6j0b+sbWTzNbM53ia/sdCrymDbgvkHUOG772iTrxkPhYN Qf/BFeU4mBJOagEb0AcVHxIpJqUZzO89Cib1921yx9TIx8dG39sVo1TV/cKSF+Wt W0DJH8wleiOTgz9FqFndaIc9F1l14EU9+64OYM8DJ6FV+IUHz4MwxvoQ4MvE25M9 gwBbGqNFxl2o0TR8K4i7Xgml/PfH5oSKaDNIumoZvhpQEvUeCHwBrk8cQ4hRkblk TEKOddlCxKPrHDEezh3Y52vlFHIrNOURh6P9l4SJjhX7jv0kOQDNUV8HvlJkfnn+ 9akwPaO4k80p2CdycNWvz56SiBNxuLERlCKQ45GKRjIBtD++Fs9Zcv6nMmzW1tTq KXJGh/nv2jXLyLw2zpo9LyTzzPduKiDKRAH7jkhuqKQhZEYNSpBLTCGb9SZAITGz LM8Czgy4WmzaLGNZ/VNE0qO7v9qWstlNsLRE8KTJjkwx0u8rvH0RceFln8z4Crjr AeX5hFUnwuF/vl1d12IfuNTMALfC+Htg1pKSRNgIe9XTLkI7OTGpbDBDg7qSPv4n 90w5DP0vKEaUHRlEtQsIGu0fbRvyX7P9jfcc+XLwvxUmO6HnhaRErqwrSsx9fqNe 29s6lM5rYhFELp1hHU60Aze7e1/wkDRD2s2TWzuK8hBv1ex5bS8= =e60D -----END PGP SIGNATURE----- --fVFr6D0NqFXFjDHvGbV1D06FjIqIpP8PE--