Re: [PATCH] [gdb] Create script to convert old tests into Dwarf::assemble calls.

[Simon Marchi <simark@simark.ca>]

On 2024-12-05 12:37, Luis Machado wrote:
> On 12/5/24 17:25, Simon Marchi wrote:
>>
>>
>> On 2024-12-05 08:55, William Ferreira wrote:
>>> PR testsuite/32261 requests a script that could convert old .S-based
>>> tests (that were made before dwarf.exp existed) into the new
>>> Dwarf::assemble calls in Tcl. This commit is an initial implementation
>>> of such a script. Python was chosen for convenience, and only relies on
>>> a single external library.
>>
>> Thanks for doing this.  I don't have time for a deep review right now,
>> but I have a few superficial comments.
>>
>> I'm not sure I would put it under testsuite/lib.  This directory
>> contains stuff used by the tests themselves (expect code) of test
>> programs.  Maybe right under testsuite?  There are already two Python
>> utils there.
> 
> How about gdb/contrib?
> 

I wouldn't expect to find things specific to the testsuite there.

Of course, to contradict that, I see there is:

  expect-read1.c
  expect-read1.sh

It seems like gdb/contrib/expect-read1.c is a simpler version of
gdb/testsuite/read1.c.  I wonder if the copy in contrib is really
used...

Simon