From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OA7sBCPnUWdrEwUAWB0awg (envelope-from ) for ; Thu, 05 Dec 2024 12:47:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733420835; bh=IeCWimK6ZxK52lDB6MDEzzNjXen2KoFX209NWvFg9o4=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hNmoujXMtxZ13v0AFwXF3+ROES9Xx6ty55OlJQNznWiFyYcrxmxr7fYPqufwyS7Tp ley91SA0rOSH1ChaHWBSWZ3jJb3XYX3UMn687QinkmPm8YukAT2/0xZFDxn7ADhsNE BQEpUMX5wanqWDxWFimA9Ot0rJKiVglVgHrtBupg= Received: by simark.ca (Postfix, from userid 112) id 108341E197; Thu, 5 Dec 2024 12:47:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=adMln6dK; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=kTmvBbhB; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B20C71E05C for ; Thu, 5 Dec 2024 12:47:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C7E43858CD9 for ; Thu, 5 Dec 2024 17:47:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C7E43858CD9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=adMln6dK; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=kTmvBbhB Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 430BF3858D21 for ; Thu, 5 Dec 2024 17:46:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 430BF3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 430BF3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733420799; cv=none; b=B+IBbh0w565zdSORj5aIi2XzKO5tiuzlH0EuMN3WOCcesnEQ5VLnw5N4dqBpYr+RjszXSnUIz+afcWziYe3dSUisN5cNgbHbRbD1r3WO0O06nIXYYmBT3rbYetV2pxDnWgmBk4nebquMGFMmAUhEbq9gQoo8WfxnuR/5CPm6HIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733420799; c=relaxed/simple; bh=IeCWimK6ZxK52lDB6MDEzzNjXen2KoFX209NWvFg9o4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=w5fdl0+6MjCkk0F1IBW4VwgwVbAA82AUmT3DAHe7eUaG4kBVMpdJPJKzYDmoiSpwxcZAhEztnSW7oUEgZHbH81vRxE8pYEDHMbC+Vu+9QKx2euWDBqXVmyC3zyDzrTblhM4EartBKlCHXZ95OH40G3Ut+rJUlFbwpHDe4ui3oNM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 430BF3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733420799; bh=IeCWimK6ZxK52lDB6MDEzzNjXen2KoFX209NWvFg9o4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=adMln6dKHUcFDT7tIwLZOJHyfzNFGHK0x0NK6MY1Ii0igL19pg3Yu/U/JYylBE7rx vXLrhL9PNxDaNDExyM8Su5B5tS+QhybjB9K0BXC5VSWZNj55o7L5C7yYM0QJnN+eVi BOYdXOr7EcxMuPdVhm74LUtbmIdT1+pTrqQ3t4qc= Received: by simark.ca (Postfix, from userid 112) id 002061E1A4; Thu, 5 Dec 2024 12:46:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733420798; bh=IeCWimK6ZxK52lDB6MDEzzNjXen2KoFX209NWvFg9o4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=kTmvBbhBvP9Gog9yzSjMncSW6CEGHATLhMiJFxfjEGbPHqzgrccti+r3RzIOydAAE bkxi5xfMqGC2n9fE7/y56GRbyAe94r14893j7ple8+J2nEH6UzUVZgxPs+lNAQxE2q xUfEcpeYGeFrbCGvuoKZobZzECYwVA5m6wSW5uv4= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E21371E05C; Thu, 5 Dec 2024 12:46:37 -0500 (EST) Message-ID: Date: Thu, 5 Dec 2024 12:46:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Create script to convert old tests into Dwarf::assemble calls. To: Luis Machado , William Ferreira , gdb-patches@sourceware.org References: <20241205135550.9320-1-wqferr@gmail.com> <5eb4ee44-8ae7-4fcc-8b1a-ee8c47ab86f2@simark.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-12-05 12:37, Luis Machado wrote: > On 12/5/24 17:25, Simon Marchi wrote: >> >> >> On 2024-12-05 08:55, William Ferreira wrote: >>> PR testsuite/32261 requests a script that could convert old .S-based >>> tests (that were made before dwarf.exp existed) into the new >>> Dwarf::assemble calls in Tcl. This commit is an initial implementation >>> of such a script. Python was chosen for convenience, and only relies on >>> a single external library. >> >> Thanks for doing this. I don't have time for a deep review right now, >> but I have a few superficial comments. >> >> I'm not sure I would put it under testsuite/lib. This directory >> contains stuff used by the tests themselves (expect code) of test >> programs. Maybe right under testsuite? There are already two Python >> utils there. > > How about gdb/contrib? > I wouldn't expect to find things specific to the testsuite there. Of course, to contradict that, I see there is: expect-read1.c expect-read1.sh It seems like gdb/contrib/expect-read1.c is a simpler version of gdb/testsuite/read1.c. I wonder if the copy in contrib is really used... Simon