From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Luis Machado <luis.machado@arm.com>,
William Ferreira <wqferr@gmail.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Create script to convert old tests into Dwarf::assemble calls.
Date: Mon, 09 Dec 2024 13:30:53 -0700 [thread overview]
Message-ID: <87plm0iooy.fsf@tromey.com> (raw)
In-Reply-To: <b8d1846a-be07-4c02-a136-36ab4476c59b@simark.ca> (Simon Marchi's message of "Thu, 5 Dec 2024 12:46:37 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>>> I'm not sure I would put it under testsuite/lib. This directory
>>> contains stuff used by the tests themselves (expect code) of test
>>> programs. Maybe right under testsuite? There are already two Python
>>> utils there.
>> How about gdb/contrib?
Simon> I wouldn't expect to find things specific to the testsuite there.
I'd also suggest contrib:
It seems to me that running this program on the existing
pre-DWARF-assembler tests is a one-time thing: we convert them, remove
the old .s files, and move on.
However, the program can also be used (or modified so it can be...) to
convert other programs to DWARF assembler. This will be useful when
writing new tests -- you can use it to generate a rough draft of the
test file.
In this case, contrib seems reasonable to me.
Another idea would be to make a new directory where we keep all the
maint-related Python code. This would make it easier for us to reuse
code, have gdb-maint-specific modules for import & sharing, etc.
Tom
next prev parent reply other threads:[~2024-12-09 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 13:55 William Ferreira
2024-12-05 17:25 ` Simon Marchi
2024-12-05 17:37 ` Luis Machado
2024-12-05 17:46 ` Simon Marchi
2024-12-05 17:48 ` Luis Machado
2024-12-09 20:30 ` Tom Tromey [this message]
2024-12-17 16:43 ` Guinevere Larsen
2024-12-17 21:36 ` William Ferreira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plm0iooy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simark@simark.ca \
--cc=wqferr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox