Re: [PATCH] sim: use -Werror when probing for supported warning flags

[John Baldwin <jhb@FreeBSD.org>]

On 4/21/21 2:04 PM, Simon Marchi via Gdb-patches wrote:
> On 2021-04-21 4:44 p.m., Mike Frysinger wrote:
>> On 21 Apr 2021 14:51, Simon Marchi via Gdb-patches wrote:
>>> When building with clang, we get:
>>>
>>>      error: unknown warning option '-Wmissing-parameter-type' [-Werror,-Wunknown-warning-option]
>>>
>>> This is because clang only warns by default when encountering an unknown
>>> warning option, and the probe for supported warning flags is done
>>> without -Werror.  All flags are therefore accepted by configure, but
>>> then it breaks when actually compiling a source file with -Werror.
>>>
>>> This is equivalent to this commit in gdb:
>>>
>>>      3e019bdc20eb81b91ab5bc774386201b874c0bac
>>>      gdb: Use -Werror when checking for (un)supported warning flags
>>>
>>> We then see some other compilation errors when building with clang and
>>> -Werror, they can be dealt with later.
>>>
>>> sim/ChangeLog:
>>>
>>> 	* m4/sim_ac_option_warnings.m4 (SIM_AC_OPTION_WARNINGS):
>>> 	Use -Werror when probing for supported warning flags.
>>
>> so this one file/line looks fine
>>
>> but the regen looks a little out of whack.  when i apply your patch and
>> regenerate everything, i don't have any aclocal.m4 changes.  why do you ?
>> are you running the tools manually and with a diff -I order ?
>> -mike
>>
> 
> I run `autoreconf -vf` inside sim/, using binaries compiled from
> upstream (not my distro's versions).

Do you have LANG set?  Maybe that affects the collating order used for
sorting?

-- 
John Baldwin