From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id plftD4qVgGAZRAAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 17:13:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 2CB561F104; Wed, 21 Apr 2021 17:13:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6CF741E783 for ; Wed, 21 Apr 2021 17:13:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE9513989C92; Wed, 21 Apr 2021 21:13:44 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 201473989C92 for ; Wed, 21 Apr 2021 21:13:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 201473989C92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jhb@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id BD9959D26B; Wed, 21 Apr 2021 21:13:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQYFL4Qbmz4VbK; Wed, 21 Apr 2021 21:13:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 445362B214; Wed, 21 Apr 2021 21:13:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH] sim: use -Werror when probing for supported warning flags To: Simon Marchi , gdb-patches@sourceware.org References: <20210421185110.2788705-1-simon.marchi@polymtl.ca> From: John Baldwin Message-ID: Date: Wed, 21 Apr 2021 14:13:41 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/21/21 2:04 PM, Simon Marchi via Gdb-patches wrote: > On 2021-04-21 4:44 p.m., Mike Frysinger wrote: >> On 21 Apr 2021 14:51, Simon Marchi via Gdb-patches wrote: >>> When building with clang, we get: >>> >>> error: unknown warning option '-Wmissing-parameter-type' [-Werror,-Wunknown-warning-option] >>> >>> This is because clang only warns by default when encountering an unknown >>> warning option, and the probe for supported warning flags is done >>> without -Werror. All flags are therefore accepted by configure, but >>> then it breaks when actually compiling a source file with -Werror. >>> >>> This is equivalent to this commit in gdb: >>> >>> 3e019bdc20eb81b91ab5bc774386201b874c0bac >>> gdb: Use -Werror when checking for (un)supported warning flags >>> >>> We then see some other compilation errors when building with clang and >>> -Werror, they can be dealt with later. >>> >>> sim/ChangeLog: >>> >>> * m4/sim_ac_option_warnings.m4 (SIM_AC_OPTION_WARNINGS): >>> Use -Werror when probing for supported warning flags. >> >> so this one file/line looks fine >> >> but the regen looks a little out of whack. when i apply your patch and >> regenerate everything, i don't have any aclocal.m4 changes. why do you ? >> are you running the tools manually and with a diff -I order ? >> -mike >> > > I run `autoreconf -vf` inside sim/, using binaries compiled from > upstream (not my distro's versions). Do you have LANG set? Maybe that affects the collating order used for sorting? -- John Baldwin