Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,
	Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: use -Werror when probing for supported warning flags
Date: Thu, 22 Apr 2021 22:30:26 -0400	[thread overview]
Message-ID: <YIIxQjvq+hX0mnXe@vapier> (raw)
In-Reply-To: <3aaed63a-9a69-5ab0-b95a-1fbbaacc8823@polymtl.ca>

On 22 Apr 2021 22:04, Simon Marchi via Gdb-patches wrote:
> On 2021-04-22 9:57 p.m., Tom Tromey wrote:
> >>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> > 
> > Simon> I run `autoreconf -vf` inside sim/, using binaries compiled from
> > Simon> upstream (not my distro's versions).
> > 
> > FWIW I found out yesterday that I can't "autoreconf" in sim/ppc.
> > It can't find AM_ZLIB.  I didn't really investigate, but I assume it's
> > missing a -I in ACLOCAL_AMFLAGS.
> 
> Indeed, I see this too:
> 
>   configure.ac:624: warning: macro 'AM_ZLIB' not found in library
> 
> If the AM_ZLIB macro is not found, how come we don't see 'AM_ZLIB'
> literally in the configure file?

i don't know why it warns.  it does work in spite.

sim/ppc/configure.ac has:
AC_CONFIG_MACRO_DIRS([../.. ../../config])

sim/ppc/../../config/ has zlib.m4.

we can double check:
$ cd sim/ppc
$ rm -f aclocal.m4 configure
$ aclocal-1.15
configure.ac:624: warning: macro 'AM_ZLIB' not found in library
$ grep zlib aclocal.m4
m4_include([../../config/zlib.m4])
$ grep AM_ZLIB *
configure.ac:AM_ZLIB
$ autoconf-2.69
$ ./configure --help | grep zlib
  --with-system-zlib      use installed libz

maybe aclocal scans for macros for warning before it loads the paths from
AC_CONFIG_MACRO_DIRS, and then uses those to expand the macros.

putting ACLOCAL_AMFLAGS into sim/ppc/Makefile.in doesn't help afaict.
-mike

  reply	other threads:[~2021-04-23  2:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 18:51 Simon Marchi via Gdb-patches
2021-04-21 20:44 ` Mike Frysinger via Gdb-patches
2021-04-21 21:04   ` Simon Marchi via Gdb-patches
2021-04-21 21:13     ` John Baldwin
2021-04-21 21:32       ` Simon Marchi via Gdb-patches
2021-04-21 22:38     ` Mike Frysinger via Gdb-patches
2021-04-21 23:39       ` Simon Marchi via Gdb-patches
2021-04-22  0:43         ` Mike Frysinger via Gdb-patches
2021-04-23  1:57     ` Tom Tromey
2021-04-23  2:04       ` Simon Marchi via Gdb-patches
2021-04-23  2:30         ` Mike Frysinger via Gdb-patches [this message]
2021-04-21 23:53 ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIIxQjvq+hX0mnXe@vapier \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox