From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lW7aK00xgmCYbQAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 22:30:37 -0400 Received: by simark.ca (Postfix, from userid 112) id A526D1F104; Thu, 22 Apr 2021 22:30:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4091E1E01F for ; Thu, 22 Apr 2021 22:30:33 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C841E3A71D22; Fri, 23 Apr 2021 02:30:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C841E3A71D22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619145032; bh=xzO2BUbQPGXGAzhuGCwEMUMNd+zfW7lybNZX2e69zic=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r103SSRxyyWjT0YZkune41/906Y6CTZygsnHoqAlo4QN36Ow2V4IPEbTxxTflzQ1M K0ydye3siE7HG9pnRrP8xcmZTW8m+wwU+Wv0OPO5ptPuP2KweI96fIT1zHP9CvzZSE zEniL0n39hqAo6qJG+ggJ90TMRhEPXqNtEbx6pVg= Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 00E5F385782F for ; Fri, 23 Apr 2021 02:30:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 00E5F385782F Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E022A34122F; Fri, 23 Apr 2021 02:30:26 +0000 (UTC) Date: Thu, 22 Apr 2021 22:30:26 -0400 To: Simon Marchi Subject: Re: [PATCH] sim: use -Werror when probing for supported warning flags Message-ID: Mail-Followup-To: Simon Marchi , Tom Tromey , Simon Marchi via Gdb-patches References: <20210421185110.2788705-1-simon.marchi@polymtl.ca> <878s59g3uc.fsf@tromey.com> <3aaed63a-9a69-5ab0-b95a-1fbbaacc8823@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3aaed63a-9a69-5ab0-b95a-1fbbaacc8823@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Tom Tromey , Simon Marchi via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 22 Apr 2021 22:04, Simon Marchi via Gdb-patches wrote: > On 2021-04-22 9:57 p.m., Tom Tromey wrote: > >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > > > Simon> I run `autoreconf -vf` inside sim/, using binaries compiled from > > Simon> upstream (not my distro's versions). > > > > FWIW I found out yesterday that I can't "autoreconf" in sim/ppc. > > It can't find AM_ZLIB. I didn't really investigate, but I assume it's > > missing a -I in ACLOCAL_AMFLAGS. > > Indeed, I see this too: > > configure.ac:624: warning: macro 'AM_ZLIB' not found in library > > If the AM_ZLIB macro is not found, how come we don't see 'AM_ZLIB' > literally in the configure file? i don't know why it warns. it does work in spite. sim/ppc/configure.ac has: AC_CONFIG_MACRO_DIRS([../.. ../../config]) sim/ppc/../../config/ has zlib.m4. we can double check: $ cd sim/ppc $ rm -f aclocal.m4 configure $ aclocal-1.15 configure.ac:624: warning: macro 'AM_ZLIB' not found in library $ grep zlib aclocal.m4 m4_include([../../config/zlib.m4]) $ grep AM_ZLIB * configure.ac:AM_ZLIB $ autoconf-2.69 $ ./configure --help | grep zlib --with-system-zlib use installed libz maybe aclocal scans for macros for warning before it loads the paths from AC_CONFIG_MACRO_DIRS, and then uses those to expand the macros. putting ACLOCAL_AMFLAGS into sim/ppc/Makefile.in doesn't help afaict. -mike