From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/coffread: simplify stab section detection
Date: Fri, 9 Jan 2026 16:38:39 -0500 [thread overview]
Message-ID: <b8a7da28-df54-4bbd-8cd5-b0a6ad895121@simark.ca> (raw)
In-Reply-To: <87ecnyldf3.fsf@tromey.com>
On 1/9/26 3:49 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> We look for stab sections for the sole purpose of emitting a warning if
> Simon> we see one. Simplify this by using a boolean to indicate if we saw a
> Simon> stab section or not. Simplify the search to just look for sections
> Simon> starting with ".stab", it should be enough for this purpose.
>
> Simon> Also, remove the make_scoped_restore that would overwrite the stab
> Simon> section vector, I'm not sure why it's there. It seems to me like it
> Simon> would cause the warning to never be shown.
>
> Looks nice, thanks.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed.
Simon
next prev parent reply other threads:[~2026-01-09 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 19:14 [PATCH 1/3] gdb/coffread: remove unnecessary forward declarations Simon Marchi
2026-01-09 19:14 ` [PATCH 2/3] gdb/coffread: remove unused fields of coff_symfile_info Simon Marchi
2026-01-09 19:24 ` Tom Tromey
2026-01-09 19:14 ` [PATCH 3/3] gdb/coffread: simplify stab section detection Simon Marchi
2026-01-09 19:29 ` Tom Tromey
2026-01-09 19:36 ` Simon Marchi
2026-01-09 19:41 ` [PATCH v2] " Simon Marchi
2026-01-09 20:49 ` Tom Tromey
2026-01-09 21:38 ` Simon Marchi [this message]
2026-01-09 19:24 ` [PATCH 1/3] gdb/coffread: remove unnecessary forward declarations Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a7da28-df54-4bbd-8cd5-b0a6ad895121@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox