Re: [PATCH 3/3] gdb/coffread: simplify stab section detection

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> We look for stab sections for the sole purpose of emitting a warning if
Simon> we see one.  Simplify this by using a boolean to indicate if we saw a
Simon> stab section or not.  Simplify the search to just look for sections
Simon> starting with ".stab", it should be enough for this purpose.

Simon> Also, remove the make_scoped_restore that would overwrite the stab
Simon> section vector, I'm not sure why it's there.  It seems to me like it
Simon> would cause the warning to never be shown.

Simon> @@ -47,7 +47,8 @@ struct coff_symfile_info
Simon>      file_ptr min_lineno_offset = 0;	/* Where in file lowest line#s are.  */
Simon>      file_ptr max_lineno_offset = 0;	/* 1+last byte of line#s in file.  */
 
Simon> -    std::vector<asection *> *stabsects;	/* .stab sections.  */
Simon> +    /* True if the symfile contains one section that starts with ".stab".  */
Simon> +    bool found_stab_section = false;

There's not really a reason to keep this in coff_symfile_info.  That
said it hardly hurts and this is definitely an improvement regardless.

Simon>    if (!(objfile->flags & OBJF_READNEVER))
Simon>      bfd_map_over_sections (abfd, coff_locate_sections, (void *) info);

... I'd imagine it's a workaround for mapping over sections like this
rather than just using foreach.  The latter makes it easier to do random
checks.

Approved-By: Tom Tromey <tom@tromey.com>

Tom