From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zze7JDVXYWmjeDcAWB0awg (envelope-from ) for ; Fri, 09 Jan 2026 14:29:57 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NwiwLy3E; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 85DA71E0B6; Fri, 09 Jan 2026 14:29:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E4A961E08D for ; Fri, 09 Jan 2026 14:29:56 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 78B6A4BA2E1E for ; Fri, 9 Jan 2026 19:29:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78B6A4BA2E1E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NwiwLy3E Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id BB7C44BA2E06 for ; Fri, 9 Jan 2026 19:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB7C44BA2E06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB7C44BA2E06 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767986969; cv=none; b=PcmBQJ/wM29YqaT29Ig9k7XxEUj4hbUbEFA4n1Ea0xf2IpBpjDZUV+nnikj43vywbi4aCaIb4YkrTk8YmoEGoVGT5HGWXJDE+VBi/Ss71kYbEH+sf3ypfBWeBQNfWUuuKEWmWpTyrVZnUReYtT39D/leuhyOl4iih+pF+sK3j94= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767986969; c=relaxed/simple; bh=o2N5Rdqo0QcXmHj+0aEUG0JwWQ5vlF0a1St9xtbpiBc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xqz9I/CtfLXl+y1W3+nbeLdvUVGWNBpadng4jqINc9fEe4TliLtmMOGTkcprkxHKO7sSaKjhEhiS3OlLXuKO4qMCRrh9dGsLDJ/18q3eqHR/XsUzcdwc1Z2yTYxCc2hpYL6vp1rDDGdU9Ci6OknJ13it7GWsuC844HU4LZRT4AQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB7C44BA2E06 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id eGYtv60J4KjfoeIApviJZ3; Fri, 09 Jan 2026 19:29:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id eIAovQJ4CjAxueIAovTQr1; Fri, 09 Jan 2026 19:29:26 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=69615716 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=9b3uNAs1OCUlyx65R5cA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q7kO9tBP1tEYiq63HXOUUxfGw3ZmE4qZAyK8ha2maSs=; b=NwiwLy3EY6MoIqQSVU1K6fzVQ8 OxHfqPTlkSHIy7zONuje2NHVTn/QTXYVKRuMQoRxwbfQe5tEWzoGk9z/OfPvmH0ujHMW6ZnfuONjc X0yJ/rskEXIkKfujUlwHbrFF0; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:47212 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1veIAo-00000001nsO-0Z5N; Fri, 09 Jan 2026 12:29:26 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb/coffread: simplify stab section detection In-Reply-To: <20260109191441.486109-3-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 9 Jan 2026 14:14:37 -0500") References: <20260109191441.486109-1-simon.marchi@efficios.com> <20260109191441.486109-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 09 Jan 2026 12:29:25 -0700 Message-ID: <87ikdalh4a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1veIAo-00000001nsO-0Z5N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net (bapiya) [75.166.246.134]:47212 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDtHOBWQkgYGTa0MH+eRyGvIrNcWOZfdsKU9mDGp/zi3xD2YCLZDxEjpEQ1PT2g6OAjRqmsM93eC8uSQnteEhzaCIgG8oh6CZxvGPVRSsMet70Tg7Jf8 9OISKonaGI2Wjr3noQVjZrodMA/2w9zsgddUmbWjzQEyWCbgB4nKuIEHyuzQqB2gC44okTwvLBUYZ+u1uiAt65SygW/ldF+8Ibk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> We look for stab sections for the sole purpose of emitting a warning if Simon> we see one. Simplify this by using a boolean to indicate if we saw a Simon> stab section or not. Simplify the search to just look for sections Simon> starting with ".stab", it should be enough for this purpose. Simon> Also, remove the make_scoped_restore that would overwrite the stab Simon> section vector, I'm not sure why it's there. It seems to me like it Simon> would cause the warning to never be shown. Simon> @@ -47,7 +47,8 @@ struct coff_symfile_info Simon> file_ptr min_lineno_offset = 0; /* Where in file lowest line#s are. */ Simon> file_ptr max_lineno_offset = 0; /* 1+last byte of line#s in file. */ Simon> - std::vector *stabsects; /* .stab sections. */ Simon> + /* True if the symfile contains one section that starts with ".stab". */ Simon> + bool found_stab_section = false; There's not really a reason to keep this in coff_symfile_info. That said it hardly hurts and this is definitely an improvement regardless. Simon> if (!(objfile->flags & OBJF_READNEVER)) Simon> bfd_map_over_sections (abfd, coff_locate_sections, (void *) info); ... I'd imagine it's a workaround for mapping over sections like this rather than just using foreach. The latter makes it easier to do random checks. Approved-By: Tom Tromey Tom