From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oVHVLnl1YWnI6jcAWB0awg (envelope-from ) for ; Fri, 09 Jan 2026 16:39:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1767994745; bh=ZBgaLGqCJjtId73X+JyWnRE8vRrYSUqnfk5ZElHWXjQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gSChwlmxq5L10RKQec20h52o7g1Q20M5n9KjyFzwO1ixPCmRsbSS607DycKmOTH9k oC4P0XXBhpmYiJZJ0cy3rEutOvubpdZ+nGZ3B+Rh4Ey/twJJSpeIKSqPRR6iDtsDR0 NEr3yGhUbEWrL9VUwdhsYlWCYM0p/voy+EYchmo0= Received: by simark.ca (Postfix, from userid 112) id B40001E08D; Fri, 09 Jan 2026 16:39:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VDcLfbG5; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C9921E08D for ; Fri, 09 Jan 2026 16:39:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7FA024BA2E22 for ; Fri, 9 Jan 2026 21:39:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FA024BA2E22 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VDcLfbG5 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA2544BA2E05 for ; Fri, 9 Jan 2026 21:38:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA2544BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA2544BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767994720; cv=none; b=S4W2QZSwGmaL4atv5LE/HMr69mHN0tcVChU+/Jxn+kk1AaXGE7GtZ9x8dL2MxaHj10WpVUScW8TkuZy4poIGE5aHb4sP/omXuf/j6x0KQ6wIaCd1JpqFndGWvJtwK//OJDzWZcrB8HvZPBmfvRIJfuRDA25mQyQCdEl3ChlzrYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767994720; c=relaxed/simple; bh=ZBgaLGqCJjtId73X+JyWnRE8vRrYSUqnfk5ZElHWXjQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=F7x8PoOIqe/isN5TKqFp2POXpSW93Ey+RDX4oes5whzuPKz6LEUkIrdcbD+KIgasxjYCvKXJdqIufoigkxr4tBgSIeOuXt/Uvc84ytI3Z5EOE7m1UwVZaKchB8pEkS80/uMl6G7ECEa64/8hew0wQLzmDdDklTAUOL8TfUnZDvs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA2544BA2E05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1767994720; bh=ZBgaLGqCJjtId73X+JyWnRE8vRrYSUqnfk5ZElHWXjQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VDcLfbG5WEhh5SbehsF8J4Vhkw8iWcWOL7pPDhPRz0qCDu1xMB0vClC50kNIpT0WF JNgE8e1MAzaVXXeNfAwIAk9ajr/9BJ5hu8M+TJ8vqZQEvM4LmsRbfm8n5ZN17n1fpH GyFpQ0e8ImqZwL7yEoYLh/16uUVwnN9qQuTpaUy4= Received: by simark.ca (Postfix) id 1456D1E08D; Fri, 09 Jan 2026 16:38:40 -0500 (EST) Message-ID: Date: Fri, 9 Jan 2026 16:38:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/coffread: simplify stab section detection To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260109191441.486109-3-simon.marchi@efficios.com> <20260109194128.525238-1-simon.marchi@efficios.com> <87ecnyldf3.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ecnyldf3.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/9/26 3:49 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> We look for stab sections for the sole purpose of emitting a warning if > Simon> we see one. Simplify this by using a boolean to indicate if we saw a > Simon> stab section or not. Simplify the search to just look for sections > Simon> starting with ".stab", it should be enough for this purpose. > > Simon> Also, remove the make_scoped_restore that would overwrite the stab > Simon> section vector, I'm not sure why it's there. It seems to me like it > Simon> would cause the warning to never be shown. > > Looks nice, thanks. > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon