From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 0/4] Include early include files with `-include`
Date: Tue, 26 Mar 2024 19:56:04 +0000 [thread overview]
Message-ID: <b7c88efc-6baa-437e-945a-59a9eb78c890@palves.net> (raw)
In-Reply-To: <a7008dd5-90f2-4a5e-aab4-759c6c82615d@efficios.com>
On 2024-03-26 19:09, Simon Marchi wrote:
> On 3/26/24 3:06 PM, Simon Marchi wrote:
>> This is v3 of:
>>
>> https://inbox.sourceware.org/gdb-patches/20240323021648.154109-1-simon.marchi@efficios.com/T/#t
>>
>> The only change in v3 concerns gdbreplay. In patch 3, use `-include
>> gdbsupport/common-defs.h` when building `gdbreplay.o`. In patch 4,
>> remove the corresponding #include in `gdbreplay.cc`.
>>
>> Simon Marchi (4):
>> gdb, gdbserver, gdbsupport: reformat some Makefile variables, one
>> entry per line
>> {gdb,gdbserver}/Makefile.in: remove unnecessary intermediary variables
>> gdb, gdbserver, gdbsupport: include early header files with `-include`
>> gdb, gdbserver, gdbsupport: remove includes of early headers
>
> Actually, there's one more change: in patch 4, make regdat.sh not output
> an include for server.h.
>
Thanks, LGTM.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2024-03-26 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 19:06 Simon Marchi
2024-03-26 19:06 ` [PATCH v3 1/4] gdb, gdbserver, gdbsupport: reformat some Makefile variables, one entry per line Simon Marchi
2024-03-26 19:06 ` [PATCH v3 2/4] {gdb, gdbserver}/Makefile.in: remove unnecessary intermediary variables Simon Marchi
2024-03-26 19:06 ` [PATCH v3 3/4] gdb, gdbserver, gdbsupport: include early header files with `-include` Simon Marchi
2024-03-26 19:06 ` [PATCH v3 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers Simon Marchi
2024-03-26 19:09 ` [PATCH v3 0/4] Include early include files with `-include` Simon Marchi
2024-03-26 19:56 ` Pedro Alves [this message]
2024-03-27 1:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7c88efc-6baa-437e-945a-59a9eb78c890@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox