From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2TyKOW0oA2Z5SRcAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 15:56:29 -0400 Received: by simark.ca (Postfix, from userid 112) id DB0891E0C0; Tue, 26 Mar 2024 15:56:29 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC7B31E08C for ; Tue, 26 Mar 2024 15:56:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0499C385841D for ; Tue, 26 Mar 2024 19:56:27 +0000 (GMT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id 409613858CD1 for ; Tue, 26 Mar 2024 19:56:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 409613858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 409613858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711482967; cv=none; b=s6LHEpyQ19faRol85+xRA17qBnFs5rhk4ZNEgZhCXGLwX/2y2tk5vcht0rB82TWNYJ7MLvDl0Gql3SFJJZpozudGFmyZXuCvdoy1xI9qBDjn0HtVyIqIczYlMXEQJOT0Ez3ipSZN+tI6XgYi/GBr8Dh94WGCQY2ED6NBgQvTmG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711482967; c=relaxed/simple; bh=MIDmvDl4KJrQTcsuxUpW6vE3lLiKwR2u0GqhI8HbZM0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=jHdvsKH1w6qgBfE5bu/6XHjF5nc95Kahh1Vj8sByNRNcd1062BCFXziATWI6JLaaoCXx31TQd3VXYmMWF2+KSUv7FJwdchFKbtWl+U5fUfv2+yhblWGJlVFvK3/ea4xO3qB5vkZaD9L9Sah2lm4o+OCzRzWKUJvCgAtm1vHE1+c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33fd12a06fdso4238792f8f.1 for ; Tue, 26 Mar 2024 12:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711482965; x=1712087765; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N8BffM1jfUSxqX44a2BtyuOUrlvlYu0uao35VQPr94E=; b=uBa6v28wVIzdK6xQfLXgxazVdNIxDi/a51G2ToPPCPJPL6LPZdqXZ8p5b/Cw8rqCSv +wZJEmnO6TmGjtP33rxElfK3bsGp/6LAs0kfHkm6uRsZwQVVaaep7uPJp1eGvisa0Ngo 1dXd75LbkbeXfFh2fIQ6eTnT+BrSNwa2JIhJYzLSS3i6+g7sjD+h2z26wOvU59pMCA0s rTWVa4pmtej2DFq+dFOOTYSq/CLmXhuejVtG1Ff3LkPhBavUxlgg63lCFhW1qbsInp0g BEoQyEF7S+nsa/AfROl4eJaxJ3ulqpM8KnTGm8h8gjYQFspTvRhTlCfA6r73TwMnwsFP qA7A== X-Forwarded-Encrypted: i=1; AJvYcCUhJSaHdf1fYehb1U/D4noUIb1kmUt5YuI347tm02EtqKiojavaEE7cEmQ6Xq2ojcLCxMIe3ohUZuFR444hN3o8OgD7XvXooUWk1g== X-Gm-Message-State: AOJu0YyCrIHK6zvHXak5wt6Ba3tYM0FkYDDS49LI1S7qAcLkw9LV2KW1 nyq8w7daEWh0evVV3Xk5kg9hhplrFj1maHoJyMP9bI2f+Uzrtp4WFUKS4WAsnjE= X-Google-Smtp-Source: AGHT+IHdqjJ1mCrfMRrfBTcpngm8zS0bUZJADD4iNLuQ5HRXCwcOyl/ijsJqhaIF6G1/b6Hjevm8/w== X-Received: by 2002:adf:f507:0:b0:33d:b2d7:6264 with SMTP id q7-20020adff507000000b0033db2d76264mr402965wro.51.1711482964941; Tue, 26 Mar 2024 12:56:04 -0700 (PDT) Received: from ?IPV6:2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08? ([2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08]) by smtp.gmail.com with ESMTPSA id b2-20020a05600003c200b00341ddb65b07sm587557wrg.63.2024.03.26.12.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 12:56:04 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 19:56:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] Include early include files with `-include` Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20240326190806.89541-1-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-26 19:09, Simon Marchi wrote: > On 3/26/24 3:06 PM, Simon Marchi wrote: >> This is v3 of: >> >> https://inbox.sourceware.org/gdb-patches/20240323021648.154109-1-simon.marchi@efficios.com/T/#t >> >> The only change in v3 concerns gdbreplay. In patch 3, use `-include >> gdbsupport/common-defs.h` when building `gdbreplay.o`. In patch 4, >> remove the corresponding #include in `gdbreplay.cc`. >> >> Simon Marchi (4): >> gdb, gdbserver, gdbsupport: reformat some Makefile variables, one >> entry per line >> {gdb,gdbserver}/Makefile.in: remove unnecessary intermediary variables >> gdb, gdbserver, gdbsupport: include early header files with `-include` >> gdb, gdbserver, gdbsupport: remove includes of early headers > > Actually, there's one more change: in patch 4, make regdat.sh not output > an include for server.h. > Thanks, LGTM. Approved-By: Pedro Alves