Re: [PATCH v3 0/4] Include early include files with `-include`

[Simon Marchi <simark@simark.ca>]

On 2024-03-26 15:56, Pedro Alves wrote:
> On 2024-03-26 19:09, Simon Marchi wrote:
>> On 3/26/24 3:06 PM, Simon Marchi wrote:
>>> This is v3 of:
>>>
>>> https://inbox.sourceware.org/gdb-patches/20240323021648.154109-1-simon.marchi@efficios.com/T/#t
>>>
>>> The only change in v3 concerns gdbreplay.  In patch 3, use `-include
>>> gdbsupport/common-defs.h` when building `gdbreplay.o`.  In patch 4,
>>> remove the corresponding #include in `gdbreplay.cc`.
>>>
>>> Simon Marchi (4):
>>>   gdb, gdbserver, gdbsupport: reformat some Makefile variables, one
>>>     entry per line
>>>   {gdb,gdbserver}/Makefile.in: remove unnecessary intermediary variables
>>>   gdb, gdbserver, gdbsupport: include early header files with `-include`
>>>   gdb, gdbserver, gdbsupport: remove includes of early headers
>>
>> Actually, there's one more change: in patch 4, make regdat.sh not output
>> an include for server.h.
>>
> 
> Thanks, LGTM.
> 
> Approved-By: Pedro Alves <pedro@palves.net>
> 

Thanks, pushed.  Let's hope it doesn't break some obscure config.

I'll go over the `C/C++ Coding Standards` wiki page and update what
needs to be updated.

Simon