From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TaNqIz1zA2b5kBcAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 21:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711502141; bh=SsJCbxjLio6VDSva5GmzKKmG8V7sjFuZk+guoIieUMo=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G9ngw9rkcAUOt8QYDuHZHe5qVaofPai1ZRX3kkgOyMtcx574Wtv4cNN8X/iq1hoHn 8t1Qp9zl4jBtG0Ieff7ppCh4lu9l3BD2UhZtsyo1r9bSTzlJTLHNtOKcHezwmprmwQ WJmmPlmNPD5PAF/nQ8cjaIJpHsxX/cN8Cvi3mOho= Received: by simark.ca (Postfix, from userid 112) id 7E7821E0C0; Tue, 26 Mar 2024 21:15:41 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=CX/W5M7V; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4AF441E08C for ; Tue, 26 Mar 2024 21:15:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ABBE33858437 for ; Wed, 27 Mar 2024 01:15:38 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id F0FC43858C36 for ; Wed, 27 Mar 2024 01:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0FC43858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0FC43858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711502120; cv=none; b=LI3up78i4FYndEym0UKQJpgOQM33epiO5/ak6yeVbhBXIO9geU179ljr8nymf/4tK5xA5SIN52Mfh3z/Cp+Ql5taMEX6wwYgh/K1zRH0Sho01h01AxOfguxGOBGbxco+sL367exc5et+2jacsVqCegP1Z1/yAfVN/+thCVsk68o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711502120; c=relaxed/simple; bh=SsJCbxjLio6VDSva5GmzKKmG8V7sjFuZk+guoIieUMo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tRjDnsRVaISAYHvqZG8z9Ns5cZe9OlhYU4f9/z6CIJzbWshTDMMsjPP26ZUNkgr6SEprap+JIK88FZe5+wedUGv6kMPtbHeQPfkQ6RU+Jqctr2McYgy7tvW1gF9njSCy2JO9ilnfsNSrdhmnJCv9thaR6xR8mYcjilzZwDNucGE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711502118; bh=SsJCbxjLio6VDSva5GmzKKmG8V7sjFuZk+guoIieUMo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=CX/W5M7VDDJ/KXSeayV7cGL2AdThMccGIHy7Xcef30Bz3KQo49RwrYU5O5c54rM89 gLM7Scg82XRd3SD+milCgNjnhn/Ny7nQq8+iA7WQryaEIzFr3TI13eBgpBosBCEUXl aHJZUDyAU5ITgH1axzS39k/9Ac5gzCOtOC9zUkS8= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5E83D1E08C; Tue, 26 Mar 2024 21:15:18 -0400 (EDT) Message-ID: <5c9d525f-3303-43e9-848a-b1e884548368@simark.ca> Date: Tue, 26 Mar 2024 21:15:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] Include early include files with `-include` Content-Language: en-US To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20240326190806.89541-1-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-26 15:56, Pedro Alves wrote: > On 2024-03-26 19:09, Simon Marchi wrote: >> On 3/26/24 3:06 PM, Simon Marchi wrote: >>> This is v3 of: >>> >>> https://inbox.sourceware.org/gdb-patches/20240323021648.154109-1-simon.marchi@efficios.com/T/#t >>> >>> The only change in v3 concerns gdbreplay. In patch 3, use `-include >>> gdbsupport/common-defs.h` when building `gdbreplay.o`. In patch 4, >>> remove the corresponding #include in `gdbreplay.cc`. >>> >>> Simon Marchi (4): >>> gdb, gdbserver, gdbsupport: reformat some Makefile variables, one >>> entry per line >>> {gdb,gdbserver}/Makefile.in: remove unnecessary intermediary variables >>> gdb, gdbserver, gdbsupport: include early header files with `-include` >>> gdb, gdbserver, gdbsupport: remove includes of early headers >> >> Actually, there's one more change: in patch 4, make regdat.sh not output >> an include for server.h. >> > > Thanks, LGTM. > > Approved-By: Pedro Alves > Thanks, pushed. Let's hope it doesn't break some obscure config. I'll go over the `C/C++ Coding Standards` wiki page and update what needs to be updated. Simon