Re: [PATCH] Logical short circuiting with Fortran argument lists

[Richard Bunt <richard.bunt@arm.com>]

On 08/07/2018 06:40 PM, Tom Tromey wrote:
>>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
> 
> Richard> While this patch allows a wider range of expressions to be evaluated, it
> Richard> should be noted that this patch does not allow the skipping of arrays
> Richard> which use Fortran array slicing, due to the inability of the debugger
> Richard> to skip OP_RANGE.
> 
>>> This sounds like a bug to me.
> 
> Richard> So this seemed like a good place to stop to keep the patch as small and
> Richard> scoped as possible.
> 
> Makes sense to me.
> 
> Richard> To satisfy this review comment, I'll add another patch to extend the
> Richard> short-circuiting to include arrays with slicing.
> 
> Sorry, I didn't meant to imply this was something you had to do.
> In fact your patch was fine with me as-is.
> 
> If you're interested in this of course I would welcome a patch :)
> Or if you wanted to just file it in bugzilla, that would be fine as well.
> 

I am interested in debugging Fortran codes so I will fix this while I am
here :). Fortunately, the re-designed fix which returns type information
even when under EVAL_SKIP fixes this issue as a side-effect. I'm just
waiting on the regression sweep to get back to me.

Many thanks,

Rich

> thanks,
> Tom
>