Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Richard Bunt <richard.bunt@arm.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org,  nd@arm.com
Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists
Date: Tue, 07 Aug 2018 17:40:00 -0000	[thread overview]
Message-ID: <87a7pyyt14.fsf@tromey.com> (raw)
In-Reply-To: <478be5c4-15c5-93e3-a55c-793557e95f9a@arm.com> (Richard Bunt's	message of "Tue, 7 Aug 2018 17:26:24 +0100")

>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:

Richard> While this patch allows a wider range of expressions to be evaluated, it
Richard> should be noted that this patch does not allow the skipping of arrays
Richard> which use Fortran array slicing, due to the inability of the debugger
Richard> to skip OP_RANGE.

>> This sounds like a bug to me.

Richard> So this seemed like a good place to stop to keep the patch as small and
Richard> scoped as possible.

Makes sense to me.

Richard> To satisfy this review comment, I'll add another patch to extend the
Richard> short-circuiting to include arrays with slicing.

Sorry, I didn't meant to imply this was something you had to do.
In fact your patch was fine with me as-is.

If you're interested in this of course I would welcome a patch :)
Or if you wanted to just file it in bugzilla, that would be fine as well.

thanks,
Tom


  reply	other threads:[~2018-08-07 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  9:32 Richard Bunt
2018-08-03 19:24 ` Simon Marchi
2018-08-06 16:35   ` Richard Bunt
2018-08-06 18:34     ` Simon Marchi
2018-08-06 19:07 ` Tom Tromey
2018-08-07 16:26   ` Richard Bunt
2018-08-07 17:40     ` Tom Tromey [this message]
2018-08-08 16:59       ` Richard Bunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7pyyt14.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=richard.bunt@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox