From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113697 invoked by alias); 7 Aug 2018 17:40:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113681 invoked by uid 89); 7 Aug 2018 17:40:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.193.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Aug 2018 17:40:52 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 87EB4401761C0 for ; Tue, 7 Aug 2018 11:43:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n5y4fS6KZBcCXn5yKf2Bn1; Tue, 07 Aug 2018 12:40:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VY6TUsD2hXtR6A91vP1YGUakvItSzXl2txb3+8rtDZE=; b=VkX0UxckCJMYuDvZKs3NynEeUj elXyw/EneWhj4b8qyAMO5VzuX56FI8lb9KFjePcmSs1vrCb7VPUil3s0gCMiN6eeIKJaz+mpbPnti jI9KvYE+Ixm0gzEtkZDlO4ozH; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:43824 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fn5y4-002o80-FZ; Tue, 07 Aug 2018 12:40:24 -0500 From: Tom Tromey To: Richard Bunt Cc: Tom Tromey , gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists References: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> <87lg9jz55b.fsf@tromey.com> <478be5c4-15c5-93e3-a55c-793557e95f9a@arm.com> Date: Tue, 07 Aug 2018 17:40:00 -0000 In-Reply-To: <478be5c4-15c5-93e3-a55c-793557e95f9a@arm.com> (Richard Bunt's message of "Tue, 7 Aug 2018 17:26:24 +0100") Message-ID: <87a7pyyt14.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00120.txt.bz2 >>>>> "Richard" == Richard Bunt writes: Richard> While this patch allows a wider range of expressions to be evaluated, it Richard> should be noted that this patch does not allow the skipping of arrays Richard> which use Fortran array slicing, due to the inability of the debugger Richard> to skip OP_RANGE. >> This sounds like a bug to me. Richard> So this seemed like a good place to stop to keep the patch as small and Richard> scoped as possible. Makes sense to me. Richard> To satisfy this review comment, I'll add another patch to extend the Richard> short-circuiting to include arrays with slicing. Sorry, I didn't meant to imply this was something you had to do. In fact your patch was fine with me as-is. If you're interested in this of course I would welcome a patch :) Or if you wanted to just file it in bugzilla, that would be fine as well. thanks, Tom