From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103661 invoked by alias); 8 Aug 2018 16:59:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103644 invoked by uid 89); 8 Aug 2018 16:59:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1336 X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20048.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 16:59:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGIXXqo4tIUfq4w9Oa9tQawQQSw3ZKCFT7soXXUxLQM=; b=my1bkd+e3+nKTMYf8DeR9nb7CljL+ixvZK1mo6TUqr4SA6w6LuShTN/m7itHS2O1d08qFnx4v/voP1hQAUFxrWaltTVLF1k8l6ldwvah6ZQu5eQFr6iq8tfDfEKE54wT4hoRmEJv+eX5kHSCHYockKrCnhxxZne663jAUmA5/DE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Richard.Bunt@arm.com; Received: from [10.32.36.144] (217.140.106.40) by VI1PR08MB3197.eurprd08.prod.outlook.com (2603:10a6:803:47::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Wed, 8 Aug 2018 16:59:51 +0000 Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists To: Tom Tromey Cc: gdb-patches@sourceware.org, nd@arm.com References: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> <87lg9jz55b.fsf@tromey.com> <478be5c4-15c5-93e3-a55c-793557e95f9a@arm.com> <87a7pyyt14.fsf@tromey.com> From: Richard Bunt Message-ID: Date: Wed, 08 Aug 2018 16:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87a7pyyt14.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: richard.bunt@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00166.txt.bz2 On 08/07/2018 06:40 PM, Tom Tromey wrote: >>>>>> "Richard" == Richard Bunt writes: > > Richard> While this patch allows a wider range of expressions to be evaluated, it > Richard> should be noted that this patch does not allow the skipping of arrays > Richard> which use Fortran array slicing, due to the inability of the debugger > Richard> to skip OP_RANGE. > >>> This sounds like a bug to me. > > Richard> So this seemed like a good place to stop to keep the patch as small and > Richard> scoped as possible. > > Makes sense to me. > > Richard> To satisfy this review comment, I'll add another patch to extend the > Richard> short-circuiting to include arrays with slicing. > > Sorry, I didn't meant to imply this was something you had to do. > In fact your patch was fine with me as-is. > > If you're interested in this of course I would welcome a patch :) > Or if you wanted to just file it in bugzilla, that would be fine as well. > I am interested in debugging Fortran codes so I will fix this while I am here :). Fortunately, the re-designed fix which returns type information even when under EVAL_SKIP fixes this issue as a side-effect. I'm just waiting on the regression sweep to get back to me. Many thanks, Rich > thanks, > Tom >