Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 2/3][gdb/testsuite] Fix global array leaks
Date: Tue, 2 Jun 2020 15:07:28 +0200	[thread overview]
Message-ID: <b4fbb91f-c4d5-f7ce-e3b5-c1402dca6fce@suse.de> (raw)
In-Reply-To: <87pnav3ezw.fsf@tromey.com>

On 22-05-2020 22:13, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Several test-cases define global arrays, which remain set after the test-case
> Tom> has run.  This has the potential to cause tcl errors.
> 
> Tom> Fix this by wrapping each test-case in a namespace.  Add a README entry on how
> Tom> to do that.
> 
> Tom> Tested on x86_64-linux.
> 
> Tom> Any comments?
> 
> This seems fine to me, but doesn't all the code in the namespace{} need
> to be reindented?

I'm not sure.

I based the style on what I saw Pedro doing here (
https://sourceware.org/git/?p=binutils-gdb.git;a=blobdiff;f=gdb/testsuite/gdb.multi/multi-kill.exp;h=03bf8449cf87694c0153e2bbb2ff476cccb1e342;hp=ce6075045fc4a9e99987067bc22e4a86e089f9d5;hb=272c36b87f81fd64e5f4669730da72c39d0716b3;hpb=013707794a67269dd34fd8ae6e354e982c547dc0
).

Thanks,
- Tom


  reply	other threads:[~2020-06-02 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 16:29 Tom de Vries
2020-05-22 20:13 ` Tom Tromey
2020-06-02 13:07   ` Tom de Vries [this message]
2020-06-02 13:24     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4fbb91f-c4d5-f7ce-e3b5-c1402dca6fce@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox