From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3][gdb/testsuite] Fix global array leaks
Date: Fri, 22 May 2020 14:13:07 -0600 [thread overview]
Message-ID: <87pnav3ezw.fsf@tromey.com> (raw)
In-Reply-To: <20200519162942.GA9014@delia> (Tom de Vries's message of "Tue, 19 May 2020 18:29:43 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Several test-cases define global arrays, which remain set after the test-case
Tom> has run. This has the potential to cause tcl errors.
Tom> Fix this by wrapping each test-case in a namespace. Add a README entry on how
Tom> to do that.
Tom> Tested on x86_64-linux.
Tom> Any comments?
This seems fine to me, but doesn't all the code in the namespace{} need
to be reindented?
Tom
next prev parent reply other threads:[~2020-05-22 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 16:29 Tom de Vries
2020-05-22 20:13 ` Tom Tromey [this message]
2020-06-02 13:07 ` Tom de Vries
2020-06-02 13:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnav3ezw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox