Re: [PATCH 2/3][gdb/testsuite] Fix global array leaks

[Pedro Alves <palves@redhat.com>]

On 6/2/20 2:07 PM, Tom de Vries wrote:
> On 22-05-2020 22:13, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Several test-cases define global arrays, which remain set after the test-case
>> Tom> has run.  This has the potential to cause tcl errors.
>>
>> Tom> Fix this by wrapping each test-case in a namespace.  Add a README entry on how
>> Tom> to do that.
>>
>> Tom> Tested on x86_64-linux.
>>
>> Tom> Any comments?
>>
>> This seems fine to me, but doesn't all the code in the namespace{} need
>> to be reindented?
> 
> I'm not sure.
> 
> I based the style on what I saw Pedro doing here (
> https://sourceware.org/git/?p=binutils-gdb.git;a=blobdiff;f=gdb/testsuite/gdb.multi/multi-kill.exp;h=03bf8449cf87694c0153e2bbb2ff476cccb1e342;hp=ce6075045fc4a9e99987067bc22e4a86e089f9d5;hb=272c36b87f81fd64e5f4669730da72c39d0716b3;hpb=013707794a67269dd34fd8ae6e354e982c547dc0
> ).
> 

I was going by:

 - we don't indent within-namespace code in C++.  And I think that's a good thing, since if
   we assume the end goal of everything being inside a namespace, then the indentation is
   just a waste of horizontal space.  TCL's usual practice may be different, I don't know.

 - reindenting everything in preexisting files seems like a lot of churn for little gain.

Thanks,
Pedro Alves